Skip to content

fix snapshots for api-generation #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix snapshots for api-generation #3932

merged 1 commit into from
Jun 3, 2025

Conversation

@jeroenvervaeke
Copy link
Member

Proposed changes

Made specToCommands function by receiving now as an argument.

@jeroenvervaeke jeroenvervaeke requested a review from a team as a code owner June 3, 2025 16:09
cveticm
cveticm approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

andreaangiolillo
andreaangiolillo approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeroenvervaeke jeroenvervaeke enabled auto-merge (squash) June 3, 2025 16:23
@jeroenvervaeke jeroenvervaeke merged commit 1a9cfce into master Jun 3, 2025
20 of 23 checks passed
@jeroenvervaeke jeroenvervaeke deleted the fix-snapshots-for-api-generation branch June 3, 2025 16:23
@jeroenvervaeke
Copy link
Member Author

It's safe to ignore Code Health / code-coverage, it's failing because the unit tests on the previous commit were failing (which is what I fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@cveticm cveticm cveticm approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeroenvervaeke @andreaangiolillo @cveticm