CLOUDP-323575: Add support to autoScalingMode in atlas clusters create #3961
Conversation
This reverts commit f3bff8f.
github-actions
bot
added
the
need-doc-review
|
Coverage Report 📈
|
|
APIx Bot |
: a message has been sent to Docs Slack channel 🚀.
| depends_on: | ||
| - name: atlas_clusters_flags_e2e | ||
| variant: "e2e_atlas_clusters" | ||
| patch_optional: true |
There was a problem hiding this comment.
is this field patch_optional new? 😮
There was a problem hiding this comment.
for other curiour rewiers
patch_optional - boolean (default: false). If true the dependency will only exist when the depended on task is present in the version at the time the dependent task is created. The depended on task will not be automatically pulled in to the version. This means that, despite the name of the field, patch_optional makes the dependency optional for all versions, not just patches.
| :copyable: false | ||
|
|
||
| # Deploy a three-member sharded cluster with independent shard scaling mode named myRS in GCP for the project with the ID 5e2211c17a3e5a48f5497de3: | ||
| atlas cluster create myRS --projectId 5e2211c17a3e5a48f5497de3 --provider GCP --region EASTERN_US --members 3 --tier M10 --mdbVersion 5.0 --diskSizeGB 10 --autoScalingMode independentShardScaling |
There was a problem hiding this comment.
[Not-blocking] do we plan to provide an alias like ISS for the flag? independentShardScaling is quite long and easy to misspell
There was a problem hiding this comment.
nice point, I'll check w/ Jonny! Did we ever provide alias for flags in the past?
| } | ||
| } | ||
|
|
||
| func removeReadOnlyAttributesLatest(out *atlasv2.ClusterDescription20240805) { |
There was a problem hiding this comment.
What does latest mean in this context? SDK? could you add a comment to clarify?
There was a problem hiding this comment.
yes, we are using latest everywhere to indicate the latest cluster definition, I can add! thx
| return cluster, nil | ||
| } | ||
|
|
||
| func (opts *CreateOpts) RunDedicatedClusterLatest() error { |
There was a problem hiding this comment.
same about latest
There was a problem hiding this comment.
thanks! I'll add in my follow-up PR since this is minor
Proposed changes
Jira ticket: CLOUDP-323575
Adds flag support to clusters create
Adds e2e tests
Adds StrictLoad file so that we can use it to identify if the file provided is ISS or not, does not impact other file loads
Evergreen patch: https://spruce.mongodb.com/version/68499b736d8b99000786d8cc/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Checklist
make fmtand formatted my codeFurther comments