Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Jun 16, 2025

Proposed changes

Jira ticket: CLOUDP-302696

  • Adds all reviewed PRs

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

blva and others added 10 commits June 6, 2025 11:18
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
)

Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <jeroen.vervaeke@mongodb.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <jeroen.vervaeke@mongodb.com>
@blva blva marked this pull request as ready for review June 17, 2025 12:44
@blva blva requested review from a team as code owners June 17, 2025 12:44
@github-actions github-actions bot added the need-doc-review Improvements or additions to documentation, will be reviewed by the docs team label Jun 17, 2025
@github-actions
Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva enabled auto-merge (squash) June 17, 2025 12:49
@blva blva requested a review from andreaangiolillo June 17, 2025 12:49
@github-actions
Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master bed65ce 25.3%
CLOUDP-302696-clusters-iss-epic dd311f3 25.5%
Difference .2%

Copy link
Contributor

@kanchana-mongodb kanchana-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

* - --autoScalingMode
- string
- false
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling.
- Mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling.

* - --autoScalingMode
- string
- false
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".
- Mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".

* - --autoScalingMode
- string
- false
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".
- Mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling. This value defaults to "clusterWideScaling".

AuditFilter = "JSON document that specifies which events to record. Escape any characters that may prevent parsing, such as single or double quotes, using a backslash (\\)."
InvitationFile = "Path to an optional JSON configuration file that defines invitation settings. Note: Unsupported fields in the JSON file are ignored."
InitDB = "Flag that uses a folder to be mapped into LOCAL deployment for initialization"
AutoScalingMode = "The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AutoScalingMode = "The mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling."
AutoScalingMode = "Mode in which the cluster scales. Valid values are clusterWideScaling or independentShardScaling."

@blva blva merged commit 4a02336 into master Jun 17, 2025
21 of 22 checks passed
@blva blva deleted the CLOUDP-302696-clusters-iss-epic branch June 17, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants