Skip to content

CLOUDP-337035 Failed to update test snapshots #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2025
Merged

CLOUDP-337035 Failed to update test snapshots #4114

merged 5 commits into from
Aug 8, 2025

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Aug 8, 2025 •
edited
Loading

Proposed changes

Failed to update test snapshots, follow up from #4108

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Failed to update test snapshots.

fmenezes
fmenezes commented Aug 8, 2025
View reviewed changes
.github/workflows/update-e2e-tests.yml
service = 'cloud'
telemetry_enabled = false
output = 'plaintext'
EOF
Copy link
Collaborator Author

@fmenezes fmenezes Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main fix

@fmenezes fmenezes marked this pull request as ready for review August 8, 2025 15:45
@fmenezes fmenezes requested a review from a team as a code owner August 8, 2025 15:45
@coveralls
Copy link
Collaborator

coveralls commented Aug 8, 2025 •
edited
Loading

Coverage Status

coverage: 64.49%. remained the same
when pulling c3e71a0 on CLOUDP-337035
into eb966e0 on master.

blva
blva previously approved these changes Aug 8, 2025
View reviewed changes
blva
blva approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit 34da433 into master Aug 8, 2025
72 of 73 checks passed
@fmenezes fmenezes deleted the CLOUDP-337035 branch August 8, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blva blva blva approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmenezes @coveralls @blva