Skip to content

CLOUDP-304203: Add support to Service Accounts #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Sep 1, 2025
Merged

CLOUDP-304203: Add support to Service Accounts #4130

merged 35 commits into from
Sep 1, 2025

Conversation

@blva
Copy link
Collaborator

@blva blva commented Aug 12, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-304203

Merges feature branch

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

cveticm and others added 30 commits August 5, 2025 09:03
@cveticm
CLOUDP-329791: refactor auth check (#4036)
5e2cfcc
@cveticm
CLOUDP-330675: Reworks atlas auth login flow (#4038)
224eacb
@cveticm
CLOUDP-330561: Moves unauth error check to common errors (#4043)
1cc527f
@cveticm
CLOUDP-329797: Make atlas config init alias of atlas auth login (#…
fa8979f 
…4044)
@cveticm
CLOUDP-331543: Replace register flow with login flow (#4051)
afeaa7a
@jeroenvervaeke @cveticm
CLOUDP-332913: [AtlasCLI] Decouple profile from viper (#4050)
25af187 
Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
@cveticm
chore: Restores changes from #4036 (#4063)
0b78713
@cveticm
CLOUDP-330235: Update config to support service accounts (#4061)
9105693
@cveticm
CLOUDP-330236: Adds NewServiceAccountTransport (#4075)
eb23c5c
@cveticm
CLOUDP-329787: Make Service Account transport available in httpClient…
4a49db9 
…() (#4090)
@cveticm
CLOUDP-329793: Replace L1 transport (#4096)
ce7c72a
@blva
CLOUDP-333260: delete api keys on logout (#4105)
7733429
@cveticm
CLOUDP-329788: Send telemetry property auth_method = service_account …
87953c8 
…when using SA (#4106)
@blva
chore: add more tests to logout before updating to config delete (#4107)
29e621d
@blva
CLOUDP-329800: reuse logout and deprecate config delete (#4112)
a18f6f5
@blva
CLOUDP-329800: Remove force when calling logout (#4117)
15b6220
@jeroenvervaeke
CLOUDP-329801: [AtlasCLI] Implement secure credential storage (#4120)
d5975ee
@blva
chore: merge from master (#4129)
f4dc6ef
@cveticm
CLOUDP-329796: Enable login via Service Account (#4118)
e0da8d1
@cveticm
chore: login help (#4132)
d6576c3
@blva @Waybo26
@fmenezes @dependabot @apix-bot
chore: merge from master (#4131)
520ac08 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Wesley Nabo <102980553+Waybo26@users.noreply.github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
@blva @fmenezes
@Waybo26 @dependabot @apix-bot @jeroenvervaeke
chore: merge all of master to feature branch (#4137)
c2c302c 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: Wesley Nabo <102980553+Waybo26@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
@jeroenvervaeke
CLOUDP-333521: [AtlasCLI] [Mac] Write e2e test for migration to secur…
4ff78c2 
…e storage (#4135)
@cveticm
CLOUDP-337696: Enable logout from Service Account (#4139)
a2e66ed
@jeroenvervaeke
CLOUDP-329803: [AtlasCLI] Document secure credential storage (#4140)
f310410
@cveticm
CLOUDP-329808: Adds service account e2e test (#4141)
d9d6c48
@blva
CLOUDP-333243: Use AtlasCLI core library for transport (#4147)
8a840a4
@blva
fix: fix purls (#4149)
90b237e
@blva @apix-bot
@jeroenvervaeke @dependabot
chore: merge master to to feature branch (#4154)
ae126c4 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@blva @apix-bot
@jeroenvervaeke @dependabot
chore: update feature branch (#4157)
daf7077 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <jeroen.vervaeke@mongodb.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cveticm and others added 3 commits August 22, 2025 19:56
@cveticm
CLOUDP-339293: Implement credential handling from atlas-cli-core (#4158)
4e97c8d
@cveticm
CLOUDP-339293: Add plugin version check (#4160)
648ab7c
@blva @fmenezes
@Waybo26 @dependabot @apix-bot @jeroenvervaeke @cveticm
chore: merge master to feature branch (#4173)
413db29 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Filipe Constantinov Menezes <filipe.menezes@mongodb.com>
Co-authored-by: Wesley Nabo <102980553+Waybo26@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: apix-bot[bot] <168195273+apix-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <9132134+jeroenvervaeke@users.noreply.github.com>
Co-authored-by: Jeroen Vervaeke <jeroen.vervaeke@mongodb.com>
Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
@blva blva changed the title DO_NOT_MERGE: Feature branch CI/CD tracking CLOUDP-304203: Add support to Service Accounts Sep 1, 2025
@blva blva marked this pull request as ready for review September 1, 2025 14:19
@blva blva requested review from a team as code owners September 1, 2025 14:19
cveticm
cveticm approved these changes Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for tackling this merge!

@blva blva enabled auto-merge (squash) September 1, 2025 14:30
@blva blva disabled auto-merge September 1, 2025 14:43
@blva blva enabled auto-merge (squash) September 1, 2025 14:49
@blva blva disabled auto-merge September 1, 2025 14:55
@blva blva merged commit 90a6c8b into master Sep 1, 2025
25 of 27 checks passed
@blva blva deleted the SA_refactor_feature_branch branch September 1, 2025 14:55
@blva blva restored the SA_refactor_feature_branch branch September 2, 2025 12:19
@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2025 •
edited
Loading

Coverage Status

coverage: 63.44% (-1.0%) from 64.472%
when pulling b35db02 on SA_refactor_feature_branch
into b5c3ba9 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cveticm cveticm cveticm approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blva @coveralls @cveticm @jeroenvervaeke