Skip to content

CLOUDP-342259: Fix snapshot testing #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

CLOUDP-342259: Fix snapshot testing #4190

wants to merge 9 commits into from

Conversation

@blva
Copy link
Collaborator

@blva blva commented Sep 4, 2025 •
edited
Loading

Proposed changes

Adds some fixes to snapshot testing

  1. We were trying to clean up more than needed, including our cloud-dev project that contains clusters that shouldn't be deleted. I added them as env variables to the cleanup step.
  2. Missing config in cleanup authentication
  3. Updating telemetry in some profiles

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the title Cloudp 342259 CLOUDP-342259: Fix snapshot testing Sep 4, 2025
@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2025 •
edited
Loading

Coverage Status

coverage: 63.889% (-0.06%) from 63.948%
when pulling 4da70f0 on CLOUDP-342259
into 12793a2 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Failed to update test snapshots.

blva
blva commented Sep 8, 2025
View reviewed changes
test/internal/cleanup_test.go
for _, project := range projects.GetResults() {
projectID := project.GetId()
if projectID == os.Getenv("MONGODB_ATLAS_PROJECT_ID") {
t.Log("skip deleting default project", projectID)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the logs, we're not detecting this env variable and not skipping the projcect succesfully

@blva blva closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blva @coveralls @cveticm