Skip to content

CLOUDP-342259: fixes search e2e test #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

CLOUDP-342259: fixes search e2e test #4196

merged 1 commit into from
Sep 9, 2025

Conversation

@blva
Copy link
Collaborator

@blva blva commented Sep 8, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-342259

This fixes the search e2e tests, we were trying to list an index that was already deleted.

atlas_search_e2e

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@coveralls
Copy link
Collaborator

coveralls commented Sep 8, 2025

Coverage Status

coverage: 63.948%. remained the same
when pulling 5dc1fa1 on CLOUDP-342259-3
into 80d80e7 on master.

blva
blva commented Sep 8, 2025
View reviewed changes
test/e2e/atlas/search/search/search_test.go
indexEntity,
"list",
"--clusterName", g.ClusterName,
"--db=sample_mflix",
Copy link
Collaborator Author

@blva blva Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were trying to list an index targeted to sample_mflix after it's deletion on line 230.

@blva blva marked this pull request as ready for review September 8, 2025 18:35
@blva blva requested a review from a team as a code owner September 8, 2025 18:35
cveticm
cveticm approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for explaining the issue also!

@blva blva merged commit c2aca7e into master Sep 9, 2025
30 checks passed
@blva blva deleted the CLOUDP-342259-3 branch September 9, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cveticm cveticm cveticm approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blva @coveralls @cveticm