-
Notifications
You must be signed in to change notification settings - Fork 89
CLOUDP-347241: Remove all references to public preview in L1 commands #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question.
Otherwise lgtm but we should hold off on merging this until all L1 work is complete.
| ExperimentalText = "The atlas api sub-command, " + | ||
| "automatically generated from the MongoDB Atlas Admin API, offers full coverage of the Admin API and " + | ||
| "is currently in Public Preview (please provide feedback " + | ||
| "at https://feedback.mongodb.com/forums/930808-atlas-cli).\n" + | ||
| "Admin API capabilities have their own release lifecycle, which you can check via the provided API endpoint " + | ||
| "documentation link.\n\n" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question: Do we want to retain some of this info in the api command long text? Specifically:
"The atlas api sub-command, automatically generated from the MongoDB Atlas Admin API, offers full coverage of the Admin API. Admin API capabilities have their own release lifecycle, which you can check via the provided API endpoint documentation link."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that information is useful. I'll add it back in but under a new name since ExperimentalText reflects it being in public preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request to edit for readability
docs/command/atlas-api-accessTracking-listAccessLogsByClusterName.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are addressed, but let's address Jonnys remarks before merging
e739b29 to
eb0281d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes - LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % copy
Co-authored-by: kanchana-mongodb <54281287+kanchana-mongodb@users.noreply.github.com>
fdca45e
Co-authored-by: kanchana-mongodb <54281287+kanchana-mongodb@users.noreply.github.com>
Proposed changes
Jira ticket: CLOUDP-347241
Checklist
make fmtand formatted my codeFurther comments