Skip to content

Conversation

Luke-Sanderson
Copy link
Collaborator

@Luke-Sanderson Luke-Sanderson commented Sep 25, 2025

Proposed changes

Jira ticket: CLOUDP-347241

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@Luke-Sanderson Luke-Sanderson requested review from a team as code owners September 25, 2025 14:46
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.
Otherwise lgtm but we should hold off on merging this until all L1 work is complete.

Comment on lines 24 to 30
ExperimentalText = "The atlas api sub-command, " +
"automatically generated from the MongoDB Atlas Admin API, offers full coverage of the Admin API and " +
"is currently in Public Preview (please provide feedback " +
"at https://feedback.mongodb.com/forums/930808-atlas-cli).\n" +
"Admin API capabilities have their own release lifecycle, which you can check via the provided API endpoint " +
"documentation link.\n\n"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question: Do we want to retain some of this info in the api command long text? Specifically:
"The atlas api sub-command, automatically generated from the MongoDB Atlas Admin API, offers full coverage of the Admin API. Admin API capabilities have their own release lifecycle, which you can check via the provided API endpoint documentation link."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that information is useful. I'll add it back in but under a new name since ExperimentalText reflects it being in public preview

Copy link

@jonnyrobots jonnyrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to edit for readability

jeroenvervaeke
jeroenvervaeke previously approved these changes Sep 26, 2025
Copy link
Member

@jeroenvervaeke jeroenvervaeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are addressed, but let's address Jonnys remarks before merging

@Luke-Sanderson Luke-Sanderson changed the base branch from master to op-id-override-feature-branch October 6, 2025 08:47
@Luke-Sanderson Luke-Sanderson changed the base branch from op-id-override-feature-branch to master October 6, 2025 09:19
Copy link

@jonnyrobots jonnyrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - LGTM!

blva
blva previously approved these changes Oct 6, 2025
Copy link
Contributor

@kanchana-mongodb kanchana-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % copy

Co-authored-by: kanchana-mongodb <54281287+kanchana-mongodb@users.noreply.github.com>
@Luke-Sanderson Luke-Sanderson dismissed stale reviews from kanchana-mongodb and blva via fdca45e October 6, 2025 12:00
Luke-Sanderson and others added 2 commits October 6, 2025 13:01
Co-authored-by: kanchana-mongodb <54281287+kanchana-mongodb@users.noreply.github.com>
@Luke-Sanderson Luke-Sanderson merged commit 114122e into master Oct 6, 2025
25 checks passed
@Luke-Sanderson Luke-Sanderson deleted the CLOUDP-347241 branch October 6, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants