Skip to content

fix: watcher overlays with get methods #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

fix: watcher overlays with get methods #4251

merged 1 commit into from
Oct 9, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Oct 8, 2025 •
edited
Loading

Proposed changes

  • Watchers are supposed to continuously query the endpoints to check if they got to their final state. This fixes with the right operation ids.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the title fix: fix watcher overlays with get methods fix: watcher overlays with get methods Oct 8, 2025
Luke-Sanderson
Luke-Sanderson approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@Luke-Sanderson Luke-Sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the misunderstanding

@blva blva marked this pull request as ready for review October 9, 2025 08:18
@blva blva requested a review from a team as a code owner October 9, 2025 08:18
@blva blva merged commit 9d8c49d into master Oct 9, 2025
27 checks passed
@blva blva deleted the fix-overlays branch October 9, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Luke-Sanderson Luke-Sanderson Luke-Sanderson approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blva @Luke-Sanderson