make linter happy

Author: s-urbaniak

test/helper/observability/exec.go

@@ -9,6 +9,7 @@ import (
 
 func ExecCommand(logger io.Writer, cmdArgs ...string) error {
 	fmt.Fprintln(logger, cmdArgs)
+	//nolint:gosec
 	out, err := exec.Command(cmdArgs[0], cmdArgs[1:]...).Output()
 	fmt.Fprintln(logger, string(out))
 

test/helper/observability/ginkgo/duration.go

@@ -57,6 +57,7 @@ func ReportDuration(ctx ginkgo.SpecContext, report ginkgotypes.Report) {
 	}
 
 	reportPath := filepath.Join(strings.TrimSpace(string(out)), "urls.json")
+	//nolint:gosec
 	file, _ := os.OpenFile(reportPath, os.O_CREATE|os.O_RDWR|os.O_TRUNC, os.ModePerm)
 	defer file.Close()
 	encoder := json.NewEncoder(file)

test/helper/observability/ginkgo/metrics.go

@@ -81,9 +81,15 @@ func sendMetrics(report types.Report) error {
 	}
 
 	data, err := proto.Marshal(req)
+	if err != nil {
+		return fmt.Errorf("error marshaling WriteRequest: %w", err)
+	}
 	compressed := snappy.Encode(nil, data)
 
 	httpReq, err := http.NewRequest("POST", "http://localhost:30000/api/v1/write", bytes.NewReader(compressed))
+	if err != nil {
+		return fmt.Errorf("error creating http request: %w", err)
+	}
 	httpReq.Header.Add("Content-Encoding", "snappy")
 	httpReq.Header.Set("Content-Type", "application/x-protobuf")
 	httpReq.Header.Set("X-Prometheus-Remote-Write-Version", "0.1.0")

test/helper/observability/install/unpack.go

@@ -25,6 +25,7 @@ func Unpack() (string, error) {
 		targetPath := filepath.Join(tempDir, path)
 
 		if d.IsDir() {
+			//nolint:gosec
 			return os.MkdirAll(targetPath, 0755)
 		}
 
@@ -35,6 +36,7 @@ func Unpack() (string, error) {
 		}
 
 		// Write to the temp directory
+		//nolint:gosec
 		err = os.WriteFile(targetPath, data, 0644)
 		if err != nil {
 			return fmt.Errorf("failed to write file %s: %w", targetPath, err)

test/helper/observability/observe/observe.go

@@ -33,6 +33,7 @@ func Observe(cmdArgs ...string) error {
 }
 
 func forwardTo(target io.Writer, cmdArgs ...string) error {
+	//nolint:gosec
 	cmd := exec.Command(cmdArgs[0], cmdArgs[1:]...)
 
 	cmdStdout, err := cmd.StdoutPipe()

test/helper/observability/snapshot/snapshot.go

@@ -19,13 +19,13 @@ import (
 func Snapshot(logger io.Writer) error {
 	kubeClient, err := kubecli.CreateNewClient()
 	if err != nil {
-		return fmt.Errorf("Failed to create client: %v", err)
+		return fmt.Errorf("Failed to create client: %w", err)
 	}
 
 	n := &corev1.Node{}
 	err = kubeClient.Get(context.Background(), client.ObjectKey{Name: "dos-control-plane"}, n)
 	if err != nil {
-		return fmt.Errorf("Failed to get dos-control-plane node: %v", err)
+		return fmt.Errorf("Failed to get dos-control-plane node: %w", err)
 	}
 	start := n.GetObjectMeta().GetCreationTimestamp()
 	now := time.Now()
@@ -46,9 +46,10 @@ Loki query:
 Parca query:
 %s
 `, promQuery, lokiQuery, parcaQuery)
+	//nolint:gosec
 	err = os.WriteFile("urls.txt", []byte(out), 0644)
 	if err != nil {
-		return fmt.Errorf("failed to write to file: %v", err)
+		return fmt.Errorf("failed to write to file: %w", err)
 	}
 
 	for _, cmdArgs := range [][]string{