Fixed swallowing python client exceptions in e2e tests

Author: lsierant

docker/mongodb-kubernetes-tests/kubetester/__init__.py

@@ -42,10 +42,12 @@ def create_or_update_secret(
     api_client: Optional[client.ApiClient] = None,
 ) -> str:
     try:
-        create_secret(namespace, name, data, type, api_client)
+        create_secret(namespace, name, data, type, api_client, )
     except kubernetes.client.ApiException as e:
         if e.status == 409:
             update_secret(namespace, name, data, api_client)
+        else:
+            raise e
 
     return name
 
@@ -161,6 +163,8 @@ def create_or_update_service(
             update_service(
                 namespace, service_name, cluster_ip=cluster_ip, ports=ports, selector=selector, service=service
             )
+        else:
+            raise e
     return service_name
 
 
@@ -269,6 +273,8 @@ def create_or_update_namespace(
     except kubernetes.client.ApiException as e:
         if e.status == 409:
             client.CoreV1Api(api_client=api_client).patch_namespace(namespace, namespace_resource)
+        else:
+            raise e
 
 
 def delete_namespace(name: str):

docker/mongodb-kubernetes-tests/kubetester/kubetester.py

@@ -303,6 +303,8 @@ def create_or_update_pvc(
                 cls.clients("corev1", api_client=api_client).patch_namespaced_persistent_volume_claim(
                     body=body, name=body["metadata"]["name"], namespace=namespace
                 )
+            else:
+                raise e
 
     @classmethod
     def delete_pvc(cls, namespace: str, name: str):

docker/mongodb-kubernetes-tests/tests/olm/olm_meko_operator_upgrade_with_resources.py

@@ -379,8 +379,8 @@ def update_subscription() -> bool:
         except kubernetes.client.ApiException as e:
             if e.status == 409:
                 return False
-        else:
-            raise e
+            else:
+                raise e
 
     run_periodically(update_subscription, timeout=100, msg="Subscription to be updated")
 

docker/mongodb-kubernetes-tests/tests/olm/olm_operator_upgrade_with_resources.py

@@ -363,8 +363,8 @@ def update_subscription() -> bool:
         except kubernetes.client.ApiException as e:
             if e.status == 409:
                 return False
-        else:
-            raise e
+            else:
+                raise e
 
     run_periodically(update_subscription, timeout=100, msg="Subscription to be updated")