Skip to content

Commit 8053895

Browse files
committed
Add timeouts to wait functions
1 parent 164f6ac commit 8053895

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docker/mongodb-kubernetes-tests/tests/authentication/mongodb_custom_roles.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ def test_changing_role(
177177
mongodb_role["spec"]["roles"][0]["role"] = "readWrite"
178178
mongodb_role.update()
179179

180-
wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1))
181-
wait_until(lambda: sharded_cluster.get_automation_config_tester().reached_version(sc_version + 1))
182-
wait_until(lambda: mc_replica_set.get_automation_config_tester().reached_version(mcrs_version + 1))
180+
wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1), timeout=120)
181+
wait_until(lambda: sharded_cluster.get_automation_config_tester().reached_version(sc_version + 1), timeout=120)
182+
wait_until(lambda: mc_replica_set.get_automation_config_tester().reached_version(mcrs_version + 1), timeout=120)
183183

184184
replica_set.get_automation_config_tester().assert_expected_role(
185185
role_index=0, expected_value=mongodb_role.get_role()
@@ -200,7 +200,7 @@ def test_removing_role_from_replica_set(replica_set: MongoDB):
200200
replica_set.update()
201201

202202
replica_set.assert_reaches_phase(Phase.Running)
203-
wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1))
203+
wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1), timeout=120)
204204
replica_set.get_automation_config_tester().assert_has_expected_number_of_roles(expected_roles=0)
205205

206206

@@ -225,7 +225,7 @@ def test_remove_role_from_sharded_cluster(sharded_cluster: MongoDB, mongodb_role
225225
sharded_cluster.update()
226226

227227
sharded_cluster.assert_reaches_phase(Phase.Running)
228-
wait_until(lambda: sharded_cluster.get_automation_config_tester().reached_version(sc_version + 1))
228+
wait_until(lambda: sharded_cluster.get_automation_config_tester().reached_version(sc_version + 1), timeout=120)
229229
sharded_cluster.get_automation_config_tester().assert_has_expected_number_of_roles(expected_roles=0)
230230

231231
# Resource should still exist since MCRS is still referencing it
@@ -243,7 +243,7 @@ def test_remove_role_from_mc_replica_set(mc_replica_set: MongoDBMulti, mongodb_r
243243
mc_replica_set.update()
244244

245245
mc_replica_set.assert_reaches_phase(Phase.Running)
246-
wait_until(lambda: mc_replica_set.get_automation_config_tester().reached_version(mcrs_version + 1))
246+
wait_until(lambda: mc_replica_set.get_automation_config_tester().reached_version(mcrs_version + 1), timeout=120)
247247
mc_replica_set.get_automation_config_tester().assert_has_expected_number_of_roles(expected_roles=0)
248248

249249
# No resources are referencing this role, should be gone

0 commit comments

Comments
 (0)