CLOUDP-323997: Refactor replicaset controller #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move reconcile hostname override cm Move reconciling of k8s resources
Julien-Ben
commented
Jun 6, 2025
| @@ -65,36 +63,7 @@ func PrepareScaleDownFromMap(omClient om.Connection, rsMembers map[string][]stri | |||
| log.Debugw("Marked replica set members as non-voting", "replica set with members", rsMembers) | |||
| } | |||
|
|
|||
| // TODO practice shows that automation agents can get stuck on setting db to "disabled" also it seems that this process | |||
There was a problem hiding this comment.
This comment dated from 2021
Julien-Ben
commented
Jun 6, 2025
| return r.updateStatus(ctx, rs, status, log) | ||
| } | ||
|
|
||
| if scale.ReplicasThisReconciliation(rs) < rs.Status.Members { |
There was a problem hiding this comment.
Not needed anymore
Related Jira ticket (from 2017): https://jira.mongodb.org/browse/HELP-3818
From the ticket, this step was necessary to scale a replica set to a single member.
We have a test covering that case
Note that the multi cluster replica set controller does not perform an equivalent step.
Julien-Ben
changed the title
Julien-Ben
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some refactoring work done in the MongoDB Replica Set controller to bring it closer to the structure of the multi cluster controller.
The aim is to break down the large reconcile loop into smaller parts
Proof of Work
We must observe no regression in E2E tests