Fix precommit, CLI tests, and image suffixes #195
Conversation
go.mod
Outdated
| @@ -13,6 +13,8 @@ require ( | |||
| github.com/hashicorp/go-retryablehttp v0.7.7 | |||
| github.com/hashicorp/vault/api v1.16.0 | |||
| github.com/imdario/mergo v0.3.15 | |||
| github.com/onsi/ginkgo/v2 v2.17.1 | |||
There was a problem hiding this comment.
from where is this coming from?
There was a problem hiding this comment.
I also saw it in my PRs, but after rebasing on master it disappeared
There was a problem hiding this comment.
Looks like I had an untracked file generated by kubebuilder. I fixed it now, thanks for catching
| @@ -14,13 +14,13 @@ WATCH_NAMESPACE=\"${WATCH_NAMESPACE}\" | |||
| NAMESPACE=\"${NAMESPACE}\" | |||
| IMAGE_PULL_POLICY=\"Always\" | |||
| MONGODB_ENTERPRISE_DATABASE_IMAGE=\"${MONGODB_ENTERPRISE_DATABASE_IMAGE:-${DATABASE_REGISTRY}/mongodb-kubernetes-database${UBI_IMAGE_SUFFIX}}\" | |||
| INIT_DATABASE_IMAGE_REPOSITORY=\"${INIT_DATABASE_REGISTRY}/mongodb-kubernetes-init-database${UBI_IMAGE_SUFFIX}\" | |||
There was a problem hiding this comment.
I see that we don't have that suffix in quay.io, but why we're changing it now?
There was a problem hiding this comment.
Will it require any changes to our local configs?
There was a problem hiding this comment.
It looks like we removed the suffixes during the merge, but this was a leftover. It still worked so far because there are some old images in ECR with the suffix.
I don't think it requires any other changes.
Summary
The precommit was not running the CLI test that generated the RBAC yaml.
The CLI test generating the RBAC yaml used broken relative paths.
Removed the -ubi suffix from local testing.
Proof of Work
The RBAC yaml has been modified with the precommit.
Checklist
Reminder (Please remove this when merging)