Skip to content

feat(NODE-6865): deprecate transaction getters #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jun 24, 2025

Description

Deprecates transaction getters that are used internally.

What is changing?

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6865

Release Highlight

Transaction state getters are deprecated.

These were for internal use only.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 24, 2025 12:19
@durran durran requested a review from a team as a code owner June 24, 2025 12:19
@baileympearson baileympearson self-assigned this Jun 24, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 24, 2025
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in the transaction class, except for the options, is internal.

  1. should options be internal too? Why do we need to expose this to users?
  2. should the whole class be internal?

@durran
Copy link
Member Author

durran commented Jun 26, 2025

Everything in the transaction class, except for the options, is internal.

1. should options be internal too?  Why do we need to expose this to users?

2. should the whole class be internal?

I've made the options internal as well but left the class public as making it internal was breaking the community types.

@durran durran requested a review from baileympearson June 26, 2025 14:13
@baileympearson baileympearson merged commit da46aea into main Jun 26, 2025
14 of 15 checks passed
@baileympearson baileympearson deleted the NODE-6865 branch June 26, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants