fix actionlint

Author: lantoli

.github/workflows/acceptance-tests-runner.yml

@@ -556,11 +556,14 @@ jobs:
           MONGODB_ATLAS_CLIENT_ID: ${{ secrets.mongodb_atlas_client_id }}
           MONGODB_ATLAS_CLIENT_SECRET: ${{ secrets.mongodb_atlas_client_secret }}
         run: |
-          ACCESS_TOKEN=$(make generate-oauth2-token)
-          if [ $? -ne 0 ] || [ -z "$ACCESS_TOKEN" ]; then
+          if ! ACCESS_TOKEN=$(make generate-oauth2-token); then
             echo "Error: Failed to generate access token"
             exit 1
           fi
+          if [ -z "$ACCESS_TOKEN" ]; then
+            echo "Error: Generated access token is empty"
+            exit 1
+          fi
           echo "access_token=$ACCESS_TOKEN" >> "$GITHUB_OUTPUT"
       - name: Acceptance Tests (Access Token)
         env:

tools/generate-oauth2-token/main.go

@@ -10,14 +10,13 @@ import (
 )
 
 func main() {
-	baseURL := os.Getenv("MONGODB_ATLAS_BASE_URL")
+	baseURL := strings.TrimRight(os.Getenv("MONGODB_ATLAS_BASE_URL"), "/")
 	clientID := os.Getenv("MONGODB_ATLAS_CLIENT_ID")
 	clientSecret := os.Getenv("MONGODB_ATLAS_CLIENT_SECRET")
 	if baseURL == "" || clientID == "" || clientSecret == "" {
 		fmt.Fprintln(os.Stderr, "Error: MONGODB_ATLAS_BASE_URL, MONGODB_ATLAS_CLIENT_ID, and MONGODB_ATLAS_CLIENT_SECRET environment variables are required")
 		os.Exit(1)
 	}
-	baseURL = strings.TrimRight(baseURL, "/")
 	conf := clientcredentials.NewConfig(clientID, clientSecret)
 	conf.TokenURL = baseURL + clientcredentials.TokenAPIPath
 	token, err := conf.Token(context.Background())