Skip to content

Conversation

@EspenAlbert
Copy link
Collaborator

Description

Removes unused RootDiskSize field and simplify ExtraAPIInfo construction

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert
Copy link
Collaborator Author

EspenAlbert commented Jan 16, 2025

Manual run in QA: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/12808761623
UPDATE: Only a single OUT_OF_CAPACITY for TestAccMockableAdvancedCluster_replicasetAdvConfigUpdate (but the mocked test passed)

@EspenAlbert EspenAlbert marked this pull request as ready for review January 16, 2025 13:47
@EspenAlbert EspenAlbert requested a review from a team as a code owner January 16, 2025 13:47
ZoneNameNumShards: numShardsMapFromOldAPI(clusterRespOld),
UsingLegacySchema: forceLegacySchema || usingLegacySchema(ctx, plan.ReplicationSpecs, diags),
}
if forceLegacySchema {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@lantoli lantoli merged commit c84ef81 into master Jan 17, 2025
71 of 75 checks passed
@lantoli lantoli deleted the adv-cluster-tpf-minor-improvements branch January 17, 2025 10:09
lantoli added a commit that referenced this pull request Jan 17, 2025
* master:
  refactor: Remove unused RootDiskSize field and simplify ExtraAPIInfo construction (#2974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants