Skip to content

chore: Unify lifecycle ingore path syntax in test so same utility function can be used #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

chore: Unify lifecycle ingore path syntax in test so same utility function can be used #3145

merged 1 commit into from
Mar 11, 2025

Conversation

@AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Mar 10, 2025

Description

Small follow up from #3136 (comment)

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@AgustinBettati
Copy link
Member Author

AgustinBettati commented Mar 10, 2025 •
edited
Loading

failing tenant test appears unrelated (flaky), ran modified test in tpf and sdk v2 test group to ensure no impact:

@AgustinBettati AgustinBettati marked this pull request as ready for review March 11, 2025 10:25
@AgustinBettati AgustinBettati requested a review from a team as a code owner March 11, 2025 10:25
@AgustinBettati AgustinBettati merged commit ba63107 into master Mar 11, 2025
96 of 97 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-304703-follow-up branch March 11, 2025 10:36
lantoli added a commit that referenced this pull request Mar 12, 2025
@lantoli
Merge branch 'master' into CLOUDP-304471_docs_improvements
9b5c46c 
* master:
  doc: Adds warning about using output variables and moved together (#3153)
  chore: Follow-up changes for PR 3140 (#3154)
  fix: Avoid inconsistent result after apply when transitioning from replica set to sharded (#3146)
  refactor: use providerName to retry when the upgrade is not completed (#3148)
  chore: Updates logic in TPF to behave similarly to SDKv2 when blocks are deleted from the config (#3140)
  doc: Updates Terraform Compatibility Matrix documentation (#3123)
  chore: Addresses "todo" comments from code (#3151)
  chore: Avoids non-empty plan after removing advanced_configuration block removal (#3134)
  chore: Unify lifecycle ingore path syntax in test so same utility function can be used (#3145)
  build(deps): bump go.mongodb.org/atlas-sdk (#3149)
  doc: Corrects schema description and docs of mongodbatlas_flex_cluster backup_settings.enabled attribute (#3143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@oarbusi oarbusi oarbusi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AgustinBettati @EspenAlbert @oarbusi