remove: Disables use of `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` #3547

maastha · 2025-08-02T01:55:03Z

Description

This PR:

disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER env variable (maybe still required to run some migration tests against versions 2.0.0)
removed advanced_cluster SDKv2 example
updates GetClusterInfo to return TPF cluster configttps://jira.mongodb.org/browse/CLOUDP-336435) (refer remove: Removes cloud_backup_schedule deprecated params #3560 for some of the test runs)
updated currently used *PreviewProviderV2* method/files names to be *MigTPF* instead

Follow-up PR #3551 updates relevant migration tests to TPF configs

Other PRs to follow-up:

Update all advanced_cluster acceptance tests to use only TPF configs & checks
Update all examples, documentation & guides to refer only TPF configs & remove references to MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER. Upgrade guide 2.0 will also be updated.
Move migration & acceptance test files to tpf package

Link to any related issue(s): CLOUDP-334497
https://jira.mongodb.org/browse/CLOUDP-336435

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

…_clusterSDKv2-b

maastha · 2025-08-06T01:43:41Z

internal/config/preview_provider_v2.go

+// TODO: delete this file once all tests are migrated to using TPF configurations
 func PreviewProviderV2AdvancedCluster() bool {
-	return previewProviderV2AdvancedCluster
+	return true


temporarily defaulting to true until all tests/code has been updated (CLOUDP-336437)

maastha · 2025-08-06T11:13:32Z

.github/workflows/examples.yml

-          terraform_wrapper: false
-      - name: tf-validate
-        run: make tools tf-validate
+# TODO: uncomment once advanced_cluster examples are updated


all pending items in this PR will be addressed in CLOUDP-336437

github-actions · 2025-08-06T11:24:36Z

APIx bot: a message has been sent to Docs Slack channel

Copilot

Pull Request Overview

This PR disables the legacy SDKv2 implementation of mongodbatlas_advanced_cluster resources and removes the MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER feature flag, transitioning fully to the Terraform Plugin Framework (TPF) implementation.

Key changes:

Removes environment variable checks and always returns true for TPF usage
Eliminates SDKv2 resource registration from provider maps
Deletes multiple SDKv2 advanced_cluster example configurations
Updates test utilities to use TPF configuration format exclusively

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/config/preview_provider_v2.go	Hardcodes TPF usage by always returning true
internal/provider/*.go	Removes conditional SDKv2 resource registration
internal/testutil/acc/*.go	Updates cluster configuration generation for TPF format
examples/mongodbatlas_advanced_cluster/*	Removes entire SDKv2 example directories
scripts/tf-validate.sh	Removes V2 schema detection logic
Makefile & .github/workflows/*	Removes environment variable usage in CI

internal/testutil/acc/config_cluster.go

EspenAlbert · 2025-08-06T13:06:47Z

examples/mongodbatlas_advanced_cluster/asymmetric-sharded-cluster/README.md

@@ -1,62 +0,0 @@
-# MongoDB Atlas Provider -- Global Cluster 


I see from the PR desc:

Update all examples, documentation & guides to refer only TPF configs & remove references to MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER

However, do we want to delete these before? I assume it might be to have all required checks pass?

don't have a strong opinion, but I think I'd leverage working in the dev branch & tackling tricky time consuming areas first. Updating examples would be easy to do later so I don't want to prioritize that right now

EspenAlbert

Great!

EspenAlbert · 2025-08-06T13:09:53Z

internal/testutil/acc/config_cluster.go

-func writeReplicationSpec(cluster *hclwrite.Body, spec admin.ReplicationSpec20240805) error {
-	replicationBlock := cluster.AppendNewBlock("replication_specs", nil).Body()
-	err := addPrimitiveAttributesViaJSON(replicationBlock, spec)
+func recursiveJSONToCty(raw any) (cty.Value, error) {


why this change?

these methods were earlier creating SDKv2 configuration for a cluster, now updated to generate TPF config instead

can you share a bit more details about recursiveJSONToCty ? was it in some other part of our code base or brand new? It just feels like a very generic util method (and I don't understand why it's needed now)

that was added to handle translation for nested objects to TF config. I've simplified the implementation now & combined this with existing handling of primitive attributes in setAttributes

EspenAlbert · 2025-08-06T13:10:47Z

internal/testutil/acc/config_cluster_test.go


 import (
 	"testing"



Why these changes? Maybe move to the plugin repo?

these methods generate SDKv2 based advanced_cluster configurations for acceptance tests from a Go object. This has now been updated to instead generate TPF configuration for advanced_cluster.
I don't see a plugin repo relevance here

jwilliams-mongo

lgtm % a few tiny tweaks to changelog entries

.changelog/3547.txt

.github/workflows/acceptance-tests-runner.yml

marcosuma · 2025-08-06T15:35:57Z

internal/testutil/acc/config_cluster.go

-func writeReplicationSpec(cluster *hclwrite.Body, spec admin.ReplicationSpec20240805) error {
-	replicationBlock := cluster.AppendNewBlock("replication_specs", nil).Body()
-	err := addPrimitiveAttributesViaJSON(replicationBlock, spec)
+func recursiveJSONToCty(raw any) (cty.Value, error) {


can you share a bit more details about recursiveJSONToCty ? was it in some other part of our code base or brand new? It just feels like a very generic util method (and I don't understand why it's needed now)

.changelog/3547.txt

Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…_clusterSDKv2-b

…ed_cluster resource (#3576)

…3555)

…arily use TPF configurations (#3565)

…_clusterSDKv2-b

…LUSTER` (#3547)

maastha and others added 9 commits August 2, 2025 03:53

adjust workflows & delete example

4083614

min required

e5df57a

fmt

9ede13c

min

4ad099d

min

bd5175c

syntax

e9c14cb

Update acceptance-tests-runner.yml

38a73d9

Update preview_provider_v2.go

a1132a9

Update shared_resource.go

cc84844

maastha changed the title ~~chore: Cloudp 334497 disable adv cluster sd kv2 b~~ chore: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER Aug 5, 2025

fmt

9b70a87

maastha changed the title ~~chore: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER~~ feat: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER Aug 5, 2025

github-actions bot added the enhancement label Aug 5, 2025

maastha changed the title ~~feat: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER~~ remove: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER Aug 5, 2025

github-actions bot removed the enhancement label Aug 5, 2025

maastha added 6 commits August 5, 2025 04:57

changelog

0bb3b8b

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-334497-disable_adv…

208afb7

…_clusterSDKv2-b

ClusterResourceHcl

ac71ea3

cleanup

c277f93

lint

8742e03

nit

a793d94

maastha commented Aug 6, 2025

View reviewed changes

maastha marked this pull request as ready for review August 6, 2025 11:24

Copilot AI review requested due to automatic review settings August 6, 2025 11:24

maastha requested review from a team as code owners August 6, 2025 11:24

Copilot AI reviewed Aug 6, 2025

View reviewed changes

internal/testutil/acc/config_cluster.go Show resolved Hide resolved

internal/testutil/acc/config_cluster.go Outdated Show resolved Hide resolved

maastha mentioned this pull request Aug 6, 2025

chore: Updates advanced_cluster migration tests to primarily use TPF #3555

Merged

13 tasks

EspenAlbert reviewed Aug 6, 2025

View reviewed changes

EspenAlbert approved these changes Aug 6, 2025

View reviewed changes

EspenAlbert reviewed Aug 6, 2025

View reviewed changes

jwilliams-mongo approved these changes Aug 6, 2025

View reviewed changes

.changelog/3547.txt Outdated Show resolved Hide resolved

.changelog/3547.txt Outdated Show resolved Hide resolved

.changelog/3547.txt Outdated Show resolved Hide resolved

marcosuma approved these changes Aug 6, 2025

View reviewed changes

marcosuma self-requested a review August 6, 2025 15:36

AgustinBettati reviewed Aug 6, 2025

View reviewed changes

.changelog/3547.txt Show resolved Hide resolved

maastha and others added 15 commits August 6, 2025 19:27

update cluster config

73d4806

Apply suggestions from code review

4acb660

Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

add env var

71454b0

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-334497-disable_adv…

b96ee55

…_clusterSDKv2-b

chore: Update repository examples to use TPF configuration for advanc…

6620cb9

…ed_cluster resource (#3576)

chore: Updates advanced_cluster migration tests to primarily use TPF (#…

df5313f

…3555)

test: Update mongodbatlas_advanced_cluster acceptance tests to prim…

8b3cc92

…arily use TPF configurations (#3565)

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-334497-disable_adv…

e83947a

…_clusterSDKv2-b

merge

794f4fb

fmt

cd8b1e3

test fix

a179588

mig test optional arg

74b581e

mig test optional arg

1bb9950

mig test optional arg

a309331

fmt

ea1dda9

maastha merged commit d39b3c1 into CLOUDP-320243-dev-2.0.0 Aug 11, 2025
39 of 42 checks passed

maastha deleted the CLOUDP-334497-disable_adv_clusterSDKv2-b branch August 11, 2025 02:23

oarbusi pushed a commit that referenced this pull request Aug 11, 2025

remove: Disables use of `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_C…

0893ccb

…LUSTER` (#3547)

remove: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER #3547

remove: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER #3547

Uh oh!

Conversation

maastha commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

maastha Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maastha Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EspenAlbert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maastha Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwilliams-mongo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

remove: Disables use of `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` #3547

remove: Disables use of `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` #3547

maastha commented Aug 2, 2025 •

edited

Loading

maastha Aug 6, 2025 •

edited

Loading

maastha Aug 6, 2025 •

edited

Loading

maastha Aug 7, 2025 •

edited

Loading