remove: Disables use of MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER

.changelog/3547.txt

@@ -0,0 +1,11 @@
+```release-note:breaking-change
+resource/mongodbatlas_advanced_cluster: Disables legacy SDKv2 implementation of this resource and removes MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER feature flag
+```
+
+```release-note:breaking-change
+data-source/mongodbatlas_advanced_cluster: Disables legacy SDKv2 implementation of this datasource and removes MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER feature flag
+```
+
+```release-note:breaking-change
+data-source/mongodbatlas_advanced_clusters: Disables legacy SDKv2 implementation of this datasource and removes MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER feature flag
+```

.github/workflows/acceptance-tests-runner.yml

@@ -380,34 +380,10 @@ jobs:
             - 'internal/service/streamprocessor/*.go'
             - 'internal/service/streamprivatelinkendpoint/*.go'
 
-  advanced_cluster:
-    needs: [ change-detection, get-provider-version ]
-    if: ${{ needs.change-detection.outputs.advanced_cluster == 'true' || inputs.test_group == 'advanced_cluster' }}
-    runs-on: ubuntu-latest
-    permissions: {}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-        with:
-          ref: ${{ inputs.ref || github.ref }}
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
-        with:
-          go-version-file: 'go.mod'
-      - uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
-        with:
-          terraform_version: ${{ inputs.terraform_version }}
-          terraform_wrapper: false  
-      - name: Acceptance Tests
-        env:
-          MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
-          ACCTEST_REGEX_RUN: ${{ inputs.reduced_tests && '^TestAccMockable' || env.ACCTEST_REGEX_RUN }}
-          ACCTEST_PACKAGES: ./internal/service/advancedcluster
-        run: make testacc
 
   advanced_cluster_tpf:
     needs: [ change-detection, get-provider-version ]
     if: ${{ needs.change-detection.outputs.advanced_cluster_tpf == 'true' || inputs.test_group == 'advanced_cluster_tpf' }}
-    env:
-      MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER: 'true'
     runs-on: ubuntu-latest
     permissions: {}
     steps:
@@ -435,7 +411,6 @@ jobs:
     needs: [ change-detection, get-provider-version ]
     if: ${{ inputs.reduced_tests == false && (needs.change-detection.outputs.advanced_cluster_tpf == 'true' || inputs.test_group == 'advanced_cluster_tpf') }}
     env:
-      MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER: 'true'
       MONGODB_ATLAS_TEST_SDKV2_TO_TPF: 'true'
     runs-on: ubuntu-latest
     permissions: {}
@@ -452,9 +427,10 @@ jobs:
           terraform_wrapper: false  
       - name: Acceptance Tests
         env:
-          MONGODB_ATLAS_LAST_VERSION: ${{ needs.get-provider-version.outputs.provider_version }}
+          MONGODB_ATLAS_LAST_VERSION:  "1.39.0" # last version that supports SDKv2 mongodbatlas_advanced_cluster
           ACCTEST_REGEX_RUN: '^TestMig'
-          ACCTEST_PACKAGES: ./internal/service/advancedcluster
+          ACCTEST_PACKAGES: |
+            ./internal/service/advancedcluster
         run: make testacc
 
   assume_role:

.github/workflows/code-health.yml

@@ -41,8 +41,6 @@ jobs:
           go-version-file: 'go.mod'
       - name: Unit Test
         run: make test
-        env:
-          MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER: "true"
   lint:
     runs-on: ubuntu-latest
     permissions: {}

.github/workflows/examples.yml

@@ -12,20 +12,21 @@ env:
   AWS_DEFAULT_REGION: us-west-2
 
 jobs:
-  tf-validate:
-    runs-on: ubuntu-latest
-    permissions: {}
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
-        with:
-          go-version-file: 'go.mod'
-      - uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
-        with:
-          terraform_version: '1.12.x'
-          terraform_wrapper: false
-      - name: tf-validate
-        run: make tools tf-validate
+# TODO: uncomment once advanced_cluster examples are updated
+  # tf-validate:
+  #   runs-on: ubuntu-latest
+  #   permissions: {}
+  #   steps:
+  #     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+  #     - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
+  #       with:
+  #         go-version-file: 'go.mod'
+  #     - uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd
+  #       with:
+  #         terraform_version: '1.12.x'
+  #         terraform_wrapper: false
+  #     - name: tf-validate
+  #       run: make tools tf-validate
   tflint:
     runs-on: ubuntu-latest
     permissions: {}

.github/workflows/update-dev-branches.yml

@@ -86,8 +86,6 @@ jobs:
     - name: Project check
       if: steps.merge-check.outputs.has-changes == 'true'
       id: project-check
-      env:
-        MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER: "true"
       run: |
         if make tools build lint test; then
           echo "slack-text=✅ Dev branch \`${{ matrix.branch }}\` merged and pushed with latest changes from master. ${{ secrets.SLACK_ONCALL_TAG }} <${{github.server_url}}/${{github.repository}}/actions/runs/${{github.run_id}}|View Action>" >> "${GITHUB_OUTPUT}"

Makefile

@@ -53,7 +53,6 @@ testmact: ## Run MacT tests (mocked acc tests)
 	@$(eval export MONGODB_ATLAS_ORG_ID?=111111111111111111111111)
 	@$(eval export MONGODB_ATLAS_PROJECT_ID?=111111111111111111111111)
 	@$(eval export MONGODB_ATLAS_CLUSTER_NAME?=mocked-cluster)
-	@$(eval export MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER?=true)
 	@if [ "$(ACCTEST_PACKAGES)" = "./..." ]; then \
 		echo "Error: ACCTEST_PACKAGES must be explicitly set for testmact target, './...' is not allowed"; \
 		exit 1; \
@@ -236,4 +235,4 @@ upload-sbom: ## Upload SBOM
 
 .PHONY: augment-sbom
 augment-sbom: ## Augment SBOM
-	./scripts/compliance/augment-sbom.sh
+	./scripts/compliance/augment-sbom.sh