chore: Fix send_notification in Test Suite #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosuma
reviewed
Oct 20, 2025
There was a problem hiding this comment.
Pull Request Overview
Enable notifications by default for test and acceptance workflows when send_notification input is unset, fixing missing Stream team alerts on scheduled runs.
- Replaces prior default false behavior with logic that treats any value not containing the substring "false" as true.
- Updates slack notification job condition to align with new default semantics.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/test-suite.yml | Changes send_notification evaluation to invert a contains('false') check and adds explanatory comment. |
| .github/workflows/acceptance-tests.yml | Aligns send_notification parameter with new contains-based logic. |
| .github/workflows/acceptance-tests-runner.yml | Updates slack notification job conditional to use the new contains-based approach. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
manupedrozo
approved these changes
Oct 20, 2025
lantoli
added a commit
that referenced
this pull request
Oct 22, 2025
* master: chore: Update SSDLC report for v2.1.0 chore: Updates CHANGELOG.md header for v2.1.0 release chore: Update example links in registry docs for v2.1.0 release chore: Add support for typed nested objects in autogen (#3801) chore: Update examples and doc to use SA instead of PAK (#3804) chore: Updates CHANGELOG.md for #3793 feat: Add workspace_name field in stream_processor resource and datasource (#3793) doc: Adds examples for advanced_cluster upgrade to v2.0 & improves documentation (#3767) chore: Fix tests using GetIndependentShardScalingMode (#3799) chore: Don't send notifications in PRs or release (#3797) test: Adds delay to avoid flakiness in TestAccProjectAPIKey_recreateWhenDeletedExternally (#3798) move CloseTokenSource call out of defer (#3796) chore: Revoke SA tokens after Terraform command finishes (#3794) chore: Fix send_notification in Test Suite (#3792) chore: Document Troubleshooting SA (#3791) build(deps): bump go.mongodb.org/atlas-sdk (#3776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix send_notification in Test Suite. Stream team is not being notified when Test Suite stream group fails.
Scheduled workflow doesn't set send_notification input so it will be enabled if not set or set to true.
I've run several Test Suite and Acceptance Tests executions to check this change. This issue was missed because scheduled workflows can't be tested in branches.
Type of change:
Required Checklist:
Further comments