Skip to content

chore: Fix send_notification in Test Suite #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 20, 2025
Merged

chore: Fix send_notification in Test Suite #3792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2502418
consider send_notification=true if
lantoli Oct 20, 2025
332983c
TEMPORARY set
lantoli Oct 20, 2025
05137df
TEMPORARY fail stream
lantoli Oct 20, 2025
ca0e354
fix send_notification as params between GHA are passed as strings
lantoli Oct 20, 2025
339c098
Revert "consider send_notification=true if"
lantoli Oct 20, 2025
f80844c
use !contains(github.event.inputs.send_notification, 'false')
lantoli Oct 20, 2025
1eed056
TEMPORARY test input param
lantoli Oct 20, 2025
5ba9d35
Revert "TEMPORARY test input param"
lantoli Oct 20, 2025
8f1b274
Revert "TEMPORARY fail stream"
lantoli Oct 20, 2025
1678ce5
Revert "TEMPORARY set"
lantoli Oct 20, 2025
d36cab3
comment
lantoli Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/acceptance-tests-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,7 @@ jobs:

slack-notification-stream:
needs: [stream]
if: ${{ !cancelled() && needs.stream.result == 'failure' && inputs.send_notification == true }}
if: ${{ !cancelled() && needs.stream.result == 'failure' && !contains(github.event.inputs.send_notification, 'false') }}
runs-on: ubuntu-latest
permissions: {}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/acceptance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
test_name: ${{ inputs.test_name }}
reduced_tests: ${{ inputs.reduced_tests || false }}
use_sa: ${{ inputs.use_sa || false }}
send_notification: ${{ inputs.send_notification || false }}
send_notification: ${{ !contains(github.event.inputs.send_notification, 'false') }}
aws_region_federation: ${{ vars.AWS_REGION_FEDERATION }}
mongodb_atlas_org_id: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_ORG_ID_CLOUD_QA || vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }}
mongodb_atlas_base_url: ${{ inputs.atlas_cloud_env == 'qa' && vars.MONGODB_ATLAS_BASE_URL_QA || vars.MONGODB_ATLAS_BASE_URL }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ jobs:
provider_version: ${{ matrix.provider_version }}
atlas_cloud_env: ${{ inputs.atlas_cloud_env || needs.variables.outputs.is_sun == 'true' && 'qa' || '' }} # Run against QA on Sundays
use_sa: ${{ needs.variables.outputs.use_sa == 'true' }}
send_notification: ${{ inputs.send_notification || false }}
# This expression is true if unset (scheduled workflow) and works with boolean and string (GHA params are passed as strings)
send_notification: ${{ !contains(github.event.inputs.send_notification, 'false') }}

clean-after:
needs: tests
if: ${{ !cancelled() }}
Expand Down