chore: Move CloseTokenSource call out of defer #3796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move CloseTokenSource call out of defer.
This is an improvement so we can call Fatal (as it was before) if
tf6server.Serve
returns an error. We can't usedefer
becauseos.Exit
inFatal
doesn't call deferred methods.Link to any related issue(s):
Type of change:
Required Checklist:
Further comments