feat: enhancement and minor optimization in Makefile (openresty#61)

Author: Kushal-kothari

Makefile

@@ -23,45 +23,43 @@ image_base="centos"
 image_tag="7"
 iteration=0
 
-# todo: optimize the code, too much duplicate code now.
+### function for building rpm
+define build_rpm
+	docker build -t apache/$(1):$(version) --build-arg checkout_v=$(checkout) \
+		-f ./dockerfiles/Dockerfile.$(2).rpm .
+endef
+
+define package_rpm
+	docker build -t apache/$(1)-packaged:$(version) \
+		--build-arg VERSION=$(version) \
+		--build-arg ITERATION=$(iteration) \
+		--build-arg PACKAGE_VERSION=$(version) \
+		-f ./dockerfiles/Dockerfile.package.$(1) .
+	docker run -d --rm --name output --net="host" apache/$(1)-packaged:$(version)
+	docker cp output:/output ${PWD}
+	docker stop output
+	docker system prune -a -f
+endef
 
 ### build apisix:
 .PHONY: build-apisix-rpm
 build-apisix-rpm:
-	docker build -t apache/apisix:$(version) --build-arg checkout_v=$(checkout) \
-		-f ./dockerfiles/Dockerfile.apisix.rpm .
+	$(call build_rpm,apisix,apisix)
 
 ### build rpm for apisix:
 .PHONY: package-apisix-rpm
 package-apisix-rpm:
-	docker build -t apache/apisix-packaged:$(version) \
-		--build-arg VERSION=$(version) \
-		--build-arg ITERATION=$(iteration) \
-		--build-arg PACKAGE_VERSION=$(version) \
-		-f ./dockerfiles/Dockerfile.package.apisix .
-	docker run -d --rm --name output --net="host" apache/apisix-packaged:$(version)
-	docker cp output:/output ${PWD}
-	docker stop output
-	docker system prune -a -f
+	$(call package_rpm,apisix)
 
 ### build dashboard:
 .PHONY: build-dashboard-rpm
 build-dashboard-rpm:
-	docker build -t apache/apisix-dashboard:$(version) --build-arg checkout_v=$(checkout) \
-		-f ./dockerfiles/Dockerfile.dashboard.rpm .
+	$(call build_rpm,apisix-dashboard,dashboard)
 
 ### build rpm for apisix dashboard:
 .PHONY: package-dashboard-rpm
 package-dashboard-rpm:
-	docker build -t apache/apisix-dashboard-packaged:$(version) \
-		--build-arg VERSION=$(version) \
-		--build-arg ITERATION=$(iteration) \
-		--build-arg PACKAGE_VERSION=$(version) \
-		-f ./dockerfiles/Dockerfile.package.apisix-dashboard .
-	docker run -d --rm --name output --net="host" apache/apisix-dashboard-packaged:$(version)
-	docker cp output:/output ${PWD}
-	docker stop output
-	docker system prune -a -f
+	$(call package_rpm,apisix-dashboard)
 
 ### build apisix-openresty:
 .PHONY: build-apisix-openresty-rpm
@@ -72,16 +70,7 @@ build-apisix-openresty-rpm:
 ### build rpm for apisix-openresty:
 .PHONY: package-apisix-openresty-rpm
 package-apisix-openresty-rpm:
-	docker build -t apache/apisix-openresty-packaged:$(version) \
-		--build-arg VERSION=$(version) \
-		--build-arg ITERATION=$(iteration) \
-		--build-arg PACKAGE_VERSION=$(version) \
-		-f ./dockerfiles/Dockerfile.package.apisix-openresty .
-	docker run -d --rm --name output --net="host" apache/apisix-openresty-packaged:$(version)
-	docker cp output:/output ${PWD}
-	docker stop output
-	docker system prune -a -f
-
+	$(call package_rpm,apisix-openresty)
 
 ### build fpm for packaging:
 .PHONY: build-fpm