-
Notifications
You must be signed in to change notification settings - Fork 527
Fix/parser improvements #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/parser improvements #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was ready to hit the merge button, except it doesn't pass CI 😄 |
I'll check it out. See if I can figure out what makes it crash. |
1318d41
to
aadbac9
Compare
3b3c04d
to
a11a28d
Compare
Can't return `T();` if `T` is a const reference type.
It's kinda weird to call it pure virtual and then implement it anyway no?
Don't skip function bodies to force template instantiations
a11a28d
to
e981c4b
Compare
duckdoom5
added a commit
to duckdoom5/CppSharp
that referenced
this pull request
Mar 4, 2025
Parser improvements Fix AST Converter missing conversion data Fix bug in test code Can't return `T();` if `T` is a const reference type. Fix clang assert Fix other test compile bug It's kinda weird to call it pure virtual and then implement it anyway no? Fix test compiler error Don't skip function bodies to force template instantiations
Is this one ready to go? |
e981c4b
to
c54f367
Compare
Yes it is :) |
tritao
reviewed
Mar 4, 2025
c54f367
to
089f802
Compare
089f802
to
b2786f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opts->verbose
andopts->skipFunctionBodies
to clang