Cleanup, quickcasting (UG), overcast table, lores dropdown#2608
Cleanup, quickcasting (UG), overcast table, lores dropdown#2608silentmark wants to merge 2 commits into
Conversation
silentmark
commented
Sep 11, 2025
silentmark
commented
- Removed unused imports from files,
- re-added quickcast from UG
- change in the way how lores for spell are being presented in sheet,
- fix for overcastpertable and re-added option to the spell sheet.
- minor null-check that sometimes happened for me.
| computeTemplates() | ||
| { | ||
| let templates = this.parent.itemTypes.template | ||
| if (!templates || templates.length == 0) return; |
There was a problem hiding this comment.
had few errors in the past so i have added this check.
There was a problem hiding this comment.
Well that doesn't make much sense, there's no reason that'd be undefined.
| <div class="form-fields"> | ||
| <input type="text" list="lores" data-action="editLore" value="{{loreValue}}"> | ||
| <select name="system.lore.value"> | ||
| {{selectOptions lores selected=source.system.lore.value}} |
There was a problem hiding this comment.
This seems like a step backwards, what is the reason? Not using select has been intentional since the creation of the system.
There was a problem hiding this comment.
ok, didnt know that it was desired. I had some problems with translations - initially it is stored as "key" but after edit - it becomes a simple string, which is causing problems in few scripts or even here:
the situation was that i had some spells that were not translated, i wanted to manually change their lore and then - some stuff stopped working.
There was a problem hiding this comment.
It is a problematic area that's always been difficult. The system should be checking to see if the input entered matches an existing lore key, if so, store the lore key, otherwise, store the input.
| <div class="form-group"> | ||
| <label>{{localize "SHEET.OtherCost"}}</label> | ||
| <input type="text" name="system.overcast.valuePerOvercast.cost" placeholder="{{localize "SHEET.OtherCostPlaceholder"}}" value="{{system.valuePerOvercast.cost}}" /> | ||
| </div> |
There was a problem hiding this comment.
Isn't this WOM specific? I don't see anything hiding this option if that's not being used.
There was a problem hiding this comment.
right, it is WoM specific, i will add the flag to check the config and display only when relevant
2 participants
