-
Notifications
You must be signed in to change notification settings - Fork 10
Wip898004 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Wip898004 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…choice and multiresponse sub-question with horizontal option #588258
File support will be added later.
Unforuntately, this puts back duplication, but there was already duplication between pmatch stand-alone and combined, which this did not solve. We should try to eliminate the duplication in future, but for now, at least we have vanilla forms code. As part of this change, I have made the display of fields consistent between the various questions types. Pmatch, pmatchexamples and pmatch-in-combined don't have exactly the same options, but the options they do have are now displayed in the same order and in the same way.
…bined question #754696
… pre-fill text given #757334
…uestion::$id #796989
…swer is of the expected form #759100
…le #486762 Applies to Pmatch/GEO/Combined Pmatch/Crossword question types
…t are not highlighted. #871005
…#subq identifier #873601 We want to replace the underscore in sub question identifier.
Also removed textarea resize option
…to new question data #890656
…sue for feedback #906132
Thanks @danghieu1407. Merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.