Skip to content

Failing core\db\plugin_checks_test::test_db_install_file test #23

@ctam

Description

@ctam

With the introduction of core\db\plugin_checks_test::test_db_install_file in MDL-85666, we might need to update the install.xml file for this test to pass.

core\db\plugin_checks_test::test_db_install_file with data set "qtype_oumultiresponse" ('qtype_oumultiresponse', 'qtype', 'oumultiresponse', '/home/runner/work/moodle/mood...sponse')
XMLDB structure does not match the install.xml file in /home/runner/work/moodle/moodle/question/type/oumultiresponse/db/install.xml
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
   <TABLES>
     <TABLE COMMENT="Options for ou multiple response questions" NAME="question_oumultiresponse">
       <FIELDS>
-        <FIELD LENGTH="10" NAME="id" NEXT="questionid" NOTNULL="true" SEQUENCE="true" TYPE="int" UNSIGNED="true"/>
-        <FIELD DEFAULT="0" LENGTH="10" NAME="questionid" NEXT="answernumbering" NOTNULL="true" PREVIOUS="id" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Indicates how and whether the choices should be numbered." DEFAULT="abc" LENGTH="10" NAME="answernumbering" NEXT="shuffleanswers" NOTNULL="true" PREVIOUS="questionid" SEQUENCE="false" TYPE="char"/>
-        <FIELD DEFAULT="1" LENGTH="4" NAME="shuffleanswers" NEXT="correctfeedback" NOTNULL="true" PREVIOUS="answernumbering" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Feedback shown for any correct response." LENGTH="small" NAME="correctfeedback" NEXT="correctfeedbackformat" NOTNULL="true" PREVIOUS="shuffleanswers" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="2" NAME="correctfeedbackformat" NEXT="partiallycorrectfeedback" NOTNULL="true" PREVIOUS="correctfeedback" SEQUENCE="false" TYPE="int" UNSIGNED="false"/>
-        <FIELD COMMENT="Feedback shown for any partially correct response." LENGTH="small" NAME="partiallycorrectfeedback" NEXT="partiallycorrectfeedbackformat" NOTNULL="true" PREVIOUS="correctfeedbackformat" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="2" NAME="partiallycorrectfeedbackformat" NEXT="incorrectfeedback" NOTNULL="true" PREVIOUS="partiallycorrectfeedback" SEQUENCE="false" TYPE="int" UNSIGNED="false"/>
-        <FIELD COMMENT="Feedback shown for any incorrect response." LENGTH="small" NAME="incorrectfeedback" NEXT="incorrectfeedbackformat" NOTNULL="true" PREVIOUS="partiallycorrectfeedbackformat" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="2" NAME="incorrectfeedbackformat" NEXT="shownumcorrect" NOTNULL="true" PREVIOUS="incorrectfeedback" SEQUENCE="false" TYPE="int" UNSIGNED="false"/>
-        <FIELD DEFAULT="0" LENGTH="2" NAME="shownumcorrect" NOTNULL="true" PREVIOUS="incorrectfeedbackformat" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
+        <FIELD LENGTH="10" NAME="id" NOTNULL="true" SEQUENCE="true" TYPE="int"/>
+        <FIELD DEFAULT="0" LENGTH="10" NAME="questionid" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Indicates how and whether the choices should be numbered." DEFAULT="abc" LENGTH="10" NAME="answernumbering" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD DEFAULT="1" LENGTH="4" NAME="shuffleanswers" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Feedback shown for any correct response." NAME="correctfeedback" NOTNULL="true" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="2" NAME="correctfeedbackformat" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Feedback shown for any partially correct response." NAME="partiallycorrectfeedback" NOTNULL="true" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="2" NAME="partiallycorrectfeedbackformat" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Feedback shown for any incorrect response." NAME="incorrectfeedback" NOTNULL="true" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="2" NAME="incorrectfeedbackformat" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD DEFAULT="0" LENGTH="2" NAME="shownumcorrect" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
         <FIELD COMMENT="Whether standard instruction ('Select one or more:') is displayed" DEFAULT="0" LENGTH="2" NAME="showstandardinstruction" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
       </FIELDS>
       <KEYS>
-        <KEY FIELDS="id" NAME="primary" NEXT="questionid" TYPE="primary"/>
-        <KEY FIELDS="questionid" NAME="questionid" PREVIOUS="primary" REFFIELDS="id" REFTABLE="question" TYPE="foreign"/>
+        <KEY FIELDS="id" NAME="primary" TYPE="primary"/>
+        <KEY FIELDS="questionid" NAME="questionid" REFFIELDS="id" REFTABLE="question" TYPE="foreign"/>
       </KEYS>
     </TABLE>
   </TABLES>

/home/runner/work/moodle/moodle/lib/tests/db/plugin_checks_test.php:55
/home/runner/work/moodle/moodle/lib/phpunit/classes/basic_testcase.php:64

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions