Skip to content

Commit 06c662f

Browse files
committed
Merge branch 'WP-5102-2' into 'MOODLE_400_STABLE'
WP-5102 add 4.5 to supported versions, remove testing on PHP7.3 See merge request workplace/moodle-mod_coursecertificate!207
2 parents ad22681 + 69b5249 commit 06c662f

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

.github/workflows/moodle-ci.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
include:
31-
- php: '7.3'
32-
moodle-branch: 'MOODLE_400_STABLE'
33-
database: pgsql
34-
extensions:
35-
civersion: 3
3631
- php: '8.0'
3732
moodle-branch: 'MOODLE_400_STABLE'
3833
database: mariadb
@@ -82,8 +77,7 @@ jobs:
8277

8378
- name: Initialise moodle-plugin-ci
8479
run: |
85-
civersion=$(if [[ "${{ matrix.civersion }}" == "3" ]]; then echo "^3"; else echo "^4"; fi)
86-
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci $civersion
80+
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
8781
echo $(cd ci/bin; pwd) >> $GITHUB_PATH
8882
echo $(cd ci/vendor/bin; pwd) >> $GITHUB_PATH
8983
sudo locale-gen en_AU.UTF-8
@@ -118,8 +112,7 @@ jobs:
118112

119113
- name: Moodle PHPDoc Checker
120114
if: ${{ always() }}
121-
# Skip for ci^3 since it may give different results on the old version and --max-warnings is not supported
122-
run: if [[ "${{ matrix.civersion }}" == "3" ]]; then true; else moodle-plugin-ci phpdoc --max-warnings 0; fi
115+
run: moodle-plugin-ci phpdoc --max-warnings 0
123116

124117
- name: Validating
125118
if: ${{ always() }}

version.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
$plugin->version = 2024090300;
3030
$plugin->requires = 2022041900.00;
3131
$plugin->maturity = MATURITY_STABLE;
32-
$plugin->supported = [400, 404];
32+
$plugin->supported = [400, 405];
3333
$plugin->dependencies = [
3434
'tool_certificate' => 2024090300,
3535
];

0 commit comments

Comments
 (0)