Skip to content

Conversation

seriousme
Copy link
Contributor

This PR adds a superseded message now that aedes-persistence-redis and aedes-persistence-mongodb no longer depend on this module. See #63

We might want to mark the package as deprecated on NPM as well using the npm deprecate command.

Kind regards,
Hans

@robertsLando
Copy link
Member

Did you actually bumped them on aedes side too?

@robertsLando robertsLando merged commit a2ec6f0 into master Jun 12, 2025
5 of 8 checks passed
@robertsLando robertsLando deleted the superseded-message branch June 12, 2025 15:42
@seriousme
Copy link
Contributor Author

Did you actually bumped them on aedes side too?

No, I only touched this one. Should I have bumped anything else?

@robertsLando
Copy link
Member

robertsLando commented Jun 16, 2025

@seriousme I think it could make sense to actually bump some of these deps on aedes side too considering we have do some major bump that would not be picked up automatically on aedes side

@seriousme
Copy link
Contributor Author

seriousme commented Jun 16, 2025

@robertsLando
I checked: https://github.com/moscajs/aedes/blob/main/package.json

And of all 4 persistency modules (memory, level, redis, mongodb) it only depends on: "aedes-persistence": "^9.1.2".
Do you want to:

  1. just bump the version of aedes-persistence ?
  2. make aedes capable of using the new async interface directly?
    2a. with automatic use of promisfiy.js if callback style persistence is detected ?
    The advantage is that users can continue as they did before, the downside is that people might never migrate and promisify.js will be there for a very long time
    2b. without automatic use of promisfiy.js , but with instructions on how to migrate?
    More painful for users, but a cleaner cut.

Kind regards,
Hans

@robertsLando
Copy link
Member

I would bump aedes persistence and use the promisfied version of persistences, once merged I will do a major bump

@seriousme
Copy link
Contributor Author

I will first try to incorporate MQTT v5 in Opifex (at least client side), and once that is done I will see what I can do with Aedes. I have too much interesting stuff for the amount of spare time that I have 😉

@seriousme
Copy link
Contributor Author

@robertsLando

I will first try to incorporate MQTT v5 in Opifex (at least client side), and once that is done I will see what I can do with Aedes. I have too much interesting stuff for the amount of spare time that I have 😉

As can be seen from tonights PR on Aedes, my curiosity won 😉. Once the dependencies are updated I will try to change the persistence interface to async.

@robertsLando
Copy link
Member

LOL, there is also MQTTv5 support on Aedes that is missing, that is a big beast: moscajs/aedes#821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants