Skip to content

feat: add additional retained match patterns with multiple wildcards to abstract.js #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

feat: add additional retained match patterns with multiple wildcards to abstract.js #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279accd
feat: add additional patterns to abstract.js
seriousme May 20, 2025
8e10ddc
feat: multiple wildcard patterns
seriousme May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions abstract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ function abstractPersistence (opts) {
throw new Error('no instance')
}

async function matchRetainedWithPattern (t, pattern) {
async function matchRetainedWithPattern (t, pattern, opts) {
const prInstance = await persistence(t)
const packet = await storeRetainedPacket(prInstance)
const packet = await storeRetainedPacket(prInstance, opts)
let stream
if (Array.isArray(pattern)) {
stream = prInstance.createRetainedStreamCombi(pattern)
Expand Down Expand Up @@ -122,11 +122,31 @@ function abstractPersistence (opts) {
await matchRetainedWithPattern(t, 'hello/+')
})

test('look up retained messages with a + as first element', async t => {
t.plan(1)
await matchRetainedWithPattern(t, '+/world')
})

test('look up retained messages with +/#', async t => {
t.plan(1)
await matchRetainedWithPattern(t, '+/#')
})

test('look up retained messages with a + and # pattern with some in between', async t => {
t.plan(1)
await matchRetainedWithPattern(t, 'hello/+/world/#', { topic: 'hello/there/world/creatures' })
})
Comment on lines +125 to +138
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also test passing an array of patterns?


test('look up retained messages with multiple patterns', async t => {
t.plan(1)
await matchRetainedWithPattern(t, ['hello/+', 'other/hello'])
})

test('look up retained messages with multiple wildcard patterns', async t => {
t.plan(1)
await matchRetainedWithPattern(t, ['hello/+', 'hel/#', 'hello/world/there/+'])
})

test('store multiple retained messages in order', async (t) => {
t.plan(1000)
const prInstance = await persistence(t)
Expand Down