fix: fix waitForReady #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
approved these changes
Mar 26, 2025
No worries, typing this from a holiday cottage right now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that I found whlle working on
aedes-persistence-mongodb. I learned that when usingaedes-cached-persistence(which builds onaedes-persistense) calls the_setupmethod of the persistence as soon asinstance.brokeris set. And as_setupemits thereadyevent, waiting for this event inabstract.jscan only happen after settinginstance.brokeror else the wait will be forever.This only touches
abstract.jswhich is only used during testing of the various persistences.Kind regards,
Hans