Skip to content

fix: skip waiting when instance is already ready #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: skip waiting when instance is already ready #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
191eade
fix: fix waitForReady
seriousme Mar 22, 2025
33b0e5c
fix: skip waiting when instance is already ready
seriousme Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions abstract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,13 +310,16 @@ function abstractPersistence (opts) {

const instance = await _persistence()
if (instance) {
// instance.broker must be set first because setting it triggers
// the call of instance._setup if aedes-cached-persistence is being used
// instance._setup then fires the 'ready'event
instance.broker = broker
// Wait for ready event, if applicable, to ensure the persistence isn't
// destroyed while it's still being set up.
// https://github.com/mcollina/aedes-persistence-redis/issues/41
if (waitForReady) {
if (waitForReady && !instance.ready) {
await waitForEvent(instance, 'ready')
}
instance.broker = broker
t.diagnostic('instance created')
return instance
}
Expand Down