Skip to content

Conversation

seriousme
Copy link
Contributor

A bug in the benchmarking report triggered a fail if the benchmark of the branch to merge scored more than the threshold over the main branch (ie. the merge branch is better), where it should fail if the score is more than the threshold below the main branch.

This PR aims to fix that, and also improves reporting in case of a fail.

Kind regards,
Hans

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.44%. Comparing base (9063215) to head (2ba6c7a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          15       15           
  Lines        1797     1797           
=======================================
  Hits         1787     1787           
  Misses         10       10           
Flag Coverage Δ
unittests 99.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertsLando robertsLando merged commit 9b76359 into moscajs:main Sep 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants