fix(dev): fix incorrect automated benchmark threshold handling #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the benchmarking report triggered a fail if the benchmark of the branch to merge scored more than the threshold over the main branch (ie. the merge branch is better), where it should fail if the score is more than the threshold below the main branch.
This PR aims to fix that, and also improves reporting in case of a fail.
Kind regards,
Hans