-
Notifications
You must be signed in to change notification settings - Fork 256
Unicode utf8 is deprecated #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5bccb00
mock translate and UnicodeUTF8 for PySide2 and PyQt5
349bed5
provide replacement for UnicodeUTF8 and new static implentation for t…
56856a0
remove double functino definition (copy and paste error)
62baab8
Merge branch 'master' into UnicodeUTF8-is-deprecated
b163772
Merge branch 'master' into UnicodeUTF8-is-deprecated
af4e8ab
add tests for PyQt5 and PySide2
4baf70c
add tests for PySide and PyQt4
1d5d9e0
fix tests
6324999
fix comment
bbd1358
move Unicode default to 0 as the call require an int
cf0f67e
review tests and module
1f139d6
fix expected argument type
bbe30b2
restore UnicodeUTF8 to None
d41d1c4
fix tests and binding for variable type on UnicodeUTF8
ef23c4b
provide tests for translate results
102ad28
remove trailing spaces
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look and see if you can't remove these whitespaces inbetween lines. A linter could help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always.
it has now been removed, and code cleaned up from trailing spaces.