feat: Add toggle to restore scroll position for same locations#15
Open
tobilen wants to merge 1 commit intomoxystudio:masterfrom
Open
feat: Add toggle to restore scroll position for same locations#15tobilen wants to merge 1 commit intomoxystudio:masterfrom
tobilen wants to merge 1 commit intomoxystudio:masterfrom
Conversation
tobilen
force-pushed
the
restore-scroll-position-for-same-sites
branch
from
f1958ae to
8a62362
Compare
This will mean that even when not using back/forward buttons, the scroll position will be restored as long as it is the same url with the same parameters.
tobilen
force-pushed
the
restore-scroll-position-for-same-sites
branch
from
8a62362 to
82fa624
Compare
Author
|
@satazor anything missing from this? fyi, i have deployed this fork to |
Author
|
@tiagodinis whats the status on this? can you give an update? |
|
:( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the scroll restoration only gets restored when the history navigation (either backwards or forwards) is used. In my case, i want the scroll restoration to be restored when a link is clicked on the page that leads to the same location as well.
This PR adds a prop called
restoreSameLocationto theRouterScrollProvider.falseby default, it will enable this behavior if it is explicitly set.Tests and documentation has been added as well. Let me know if anything is missing