What's lifecycle of agent/mcp_client

[femto]

Hello, when checking out the code,
I found mcp_client has disconnect method,
but I can't find where to call it.
Generally agent should have a close method,
then agent.close()-->mcp_client.disconnect(),
but I can't find any,
so the lifecycle is confusing to me.

[njbrake]

Thanks for the report, @femto: In our testing, here's what we currently do:

any-agent/tests/integration/mcp/test_mcp_serve.py

Lines 135 to 136 in bda7c65

	for mcp_client in main_agent._mcp_clients:
	await mcp_client.disconnect()

This way you can force the immediate closing of the client, instead of relying on the python garbage collector to handle the cleanup when the agent is deleted and the destructors run.

We've gone back and forth about how to handle this, because there are some complexities with trying to force an mcp connection closed in sync environments (#807).

Hopefully this helps!

[njbrake]

Follow up to this one: I went ahead and implemented #835 which should resolve that issue as well as the issue you reported in the other issue #829 .

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.