Skip to content

Default charset for json is utf8 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Default charset for json is utf8 #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4fec8c
Default charset for json is utf-8
jendrusk Jun 17, 2020
dd0a607
Merge pull request #1 from jendrusk/jendrusk-json-utf8
jendrusk Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions agithub/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,13 @@ def parseContentType(self, ctype):
self.ctypeParameters = {}

if 'charset' not in self.ctypeParameters:
self.ctypeParameters['charset'] = 'ISO-8859-1'
# NB: INO-8859-1 is specified (RFC 2068) as the default
# charset in case none is provided
if ctype == 'application/json':
self.ctypeParameters['charset'] = 'utf8'
# RFC 4627 says JSON text SHALL be encoded in Unicode. The default encoding is UTF-8.
else:
self.ctypeParameters['charset'] = 'ISO-8859-1'
# NB: INO-8859-1 is specified (RFC 2068) as the default
# charset in case none is provided

def mangled_mtype(self):
"""
Expand Down