Skip to content

Commit 008342a

Browse files
committed
task: cleanup unit tests
1 parent 723c22a commit 008342a

File tree

1 file changed

+7
-17
lines changed

1 file changed

+7
-17
lines changed

tests/FixedMathSharp.Tests/Fixed4x4.Tests.cs

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ public void FixedMatrix4x4_CreateTranslation_WorksCorrectly()
3838
var matrix = Fixed4x4.CreateTranslation(translation);
3939

4040
// Extract the translation to verify
41-
var extractedTranslation = matrix.ExtractTranslation();
42-
43-
Assert.Equal(translation, extractedTranslation);
41+
Assert.Equal(translation, matrix.Translation);
4442
}
4543

4644
[Fact]
@@ -50,9 +48,7 @@ public void FixedMatrix4x4_CreateScale_WorksCorrectly()
5048
var matrix = Fixed4x4.CreateScale(scale);
5149

5250
// Extract the scale to verify
53-
var extractedScale = matrix.ExtractScale();
54-
55-
Assert.Equal(scale, extractedScale);
51+
Assert.Equal(scale, matrix.Scale);
5652
}
5753

5854
[Fact]
@@ -84,14 +80,10 @@ public void FixedMatrix4x4_SetTransform_WorksCorrectly()
8480
matrix.SetTransform(translation, rotation, scale);
8581

8682
// Extract and validate translation, scale, and rotation
87-
var extractedTranslation = matrix.ExtractTranslation();
88-
var extractedScale = matrix.ExtractScale();
89-
var extractedRotation = matrix.ExtractRotation();
90-
91-
Assert.Equal(translation, extractedTranslation);
92-
Assert.Equal(scale, extractedScale);
93-
Assert.True(extractedRotation.FuzzyEqual(rotation, new Fixed64(0.0001)),
94-
$"Extracted rotation {extractedRotation} does not match expected {rotation}.");
83+
Assert.Equal(translation, matrix.Translation);
84+
Assert.Equal(scale, matrix.Scale);
85+
Assert.True(matrix.Rotation.FuzzyEqual(rotation, new Fixed64(0.0001)),
86+
$"Extracted rotation {matrix.Rotation} does not match expected {rotation}.");
9587
}
9688

9789
[Fact]
@@ -248,9 +240,7 @@ public void FixedMatrix4x4_SetGlobalScale_WorksWithoutRotation()
248240
matrix.SetGlobalScale(globalScale);
249241

250242
// Extract the final scale
251-
var extractedScale = matrix.ExtractScale();
252-
253-
Assert.Equal(globalScale, extractedScale);
243+
Assert.Equal(globalScale, matrix.Scale);
254244
}
255245

256246
[Fact]

0 commit comments

Comments
 (0)