Skip to content

Commit 6345e8f

Browse files
dnhatnmridula-s109
authored andcommitted
Rename prepareProcessPage to prepareProcessRawInputPage (elastic#130487)
This PR proposes renaming `prepareProcessPage` to `prepareProcessRawInputPage` for two reasons: 1. The name `prepareProcessPage` can be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input. 2. I plan to add `prepareProcessIntermediateInputPage`, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results.
1 parent 736fc6f commit 6345e8f

File tree

87 files changed

+94
-94
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+94
-94
lines changed

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ private TypeSpec type() {
200200
builder.addMethod(ctor());
201201
builder.addMethod(intermediateStateDesc());
202202
builder.addMethod(intermediateBlockCount());
203-
builder.addMethod(prepareProcessPage());
203+
builder.addMethod(prepareProcessRawInputPage());
204204
for (ClassName groupIdClass : GROUP_IDS_CLASSES) {
205205
builder.addMethod(addRawInputLoop(groupIdClass, blockType(aggParam.type())));
206206
builder.addMethod(addRawInputLoop(groupIdClass, vectorType(aggParam.type())));
@@ -315,10 +315,10 @@ private MethodSpec intermediateBlockCount() {
315315
}
316316

317317
/**
318-
* Prepare to process a single page of results.
318+
* Prepare to process a single raw input page.
319319
*/
320-
private MethodSpec prepareProcessPage() {
321-
MethodSpec.Builder builder = MethodSpec.methodBuilder("prepareProcessPage");
320+
private MethodSpec prepareProcessRawInputPage() {
321+
MethodSpec.Builder builder = MethodSpec.methodBuilder("prepareProcessRawInputPage");
322322
builder.addAnnotation(Override.class).addModifiers(Modifier.PUBLIC).returns(GROUPING_AGGREGATOR_FUNCTION_ADD_INPUT);
323323
builder.addParameter(SEEN_GROUP_IDS, "seenGroupIds").addParameter(PAGE, "page");
324324

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBooleanGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBytesRefGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctDoubleGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctFloatGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctIntGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctLongGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/FirstOverTimeDoubleGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/FirstOverTimeFloatGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/FirstOverTimeIntGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)