Skip to content

Support images from media library #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Support images from media library #11

wants to merge 26 commits into from

Conversation

bglgwyng
Copy link
Contributor

@bglgwyng bglgwyng commented Jul 7, 2025 •
edited
Loading

Add loadFromAssetAsync method to support load image from media library on iOS

@bglgwyng bglgwyng changed the title [WIP] Support images from media library Support images from media library Jul 8, 2025
@bglgwyng bglgwyng force-pushed the support-images-from-media-library branch from 08bf5ba to e06fdaf Compare July 8, 2025 08:13
mrousavy
mrousavy requested changes Jul 8, 2025
View reviewed changes
Copy link
Owner

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - you said this PR is now ready for review, but there is no implementation at all for Android.
This won't even build.

I also left a few comments on code styling, some Swift tips.

mrousavy
mrousavy reviewed Jul 8, 2025
View reviewed changes
bglgwyng and others added 5 commits July 9, 2025 01:51
@bglgwyng @mrousavy
doc: update the loadFromAssetAsync description
f9fd4ce 
Co-authored-by: Marc Rousavy <me@mrousavy.com>
@bglgwyng @mrousavy
style: format
5f20be4 
Co-authored-by: Marc Rousavy <me@mrousavy.com>
@bglgwyng @mrousavy
style: format
efd82c3 
Co-authored-by: Marc Rousavy <me@mrousavy.com>
@bglgwyng @mrousavy
fix: fix asset not found error message
fa2dd0b 
Co-authored-by: Marc Rousavy <me@mrousavy.com>
@bglgwyng
refactor: move orientation mapping to CGImagePropertyOrientation ex…
a1c92f1 
…tension
@bglgwyng bglgwyng force-pushed the support-images-from-media-library branch from 04003fc to a1c92f1 Compare July 9, 2025 05:14
@bglgwyng bglgwyng requested a review from mrousavy July 9, 2025 08:55
@bglgwyng
Copy link
Contributor Author

bglgwyng commented Jul 9, 2025

@mrousavy Isn't bun lint --fix enough? I ran it but there are still style errors

@bglgwyng bglgwyng marked this pull request as draft July 9, 2025 10:02
@bglgwyng bglgwyng mentioned this pull request Jul 12, 2025
Merged
@bglgwyng bglgwyng marked this pull request as ready for review July 19, 2025 11:28
@bglgwyng bglgwyng force-pushed the support-images-from-media-library branch from 0d97270 to 67d87f5 Compare July 23, 2025 15:19
@mrousavy
Copy link
Owner

Sorry I rewrote the whole NitroImage repo....

@mrousavy
Copy link
Owner

I will try to port that over to the new codebase soon. Sorry

@bglgwyng bglgwyng closed this Jul 28, 2025
@mrousavy
Copy link
Owner

let's keep it open so I don't forget

@mrousavy mrousavy reopened this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrousavy mrousavy Awaiting requested review from mrousavy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bglgwyng @mrousavy