Fix specs on TruffleRuby #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffleRuby release
|
Interesting @andrykonchin, I'm sorry I never saw this PR. Are you testing using TruffleRuby? I had removed it from CI, is that right? So you are running the specs on TruffleRuby manually? |
|
Yeah, I am running specs on TruffleRuby manually. I was reviewing patches made by the TruffleRuby team in public gems to find which are already outdated and remove them. Here in this PR I remove such an outdated TruffleRuby-specific change. Actually the specs pass without any error on TruffleRuby master now. |
|
Interesting, so should I merge this as-is @andrykonchin or are you planning to change this PR first? Not quite sure I understood |
|
Yes, please merge it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a fix for TruffleRuby in specs to have them passed on the current TruffleRuby release (24.0).