Skip to content

my plans for the library #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msarsha opened this issue Feb 2, 2018 · 3 comments
Closed

my plans for the library #54

msarsha opened this issue Feb 2, 2018 · 3 comments
Labels

Comments

@msarsha
Copy link
Owner

msarsha commented Feb 2, 2018

Hey everyone!

Now that the development env and development experience are improved I have some ideas I would like to implement.

First, the API has to change or be extended to allow the use of ng-template and\or content projections

This will give consumers a more flexible API.

Then, I would like to enhance the library with some extra features like suggested at #41 by @AlexLnz

I believe an improved API will allow us implement features more easily.

@msarsha
Copy link
Owner Author

msarsha commented Feb 2, 2018

@Hughp135

@Hughp135
Copy link
Contributor

I agree templates would be a nice addition for the library.

Personally, I think the menu reposition feature in #46 is an essential feature as I am currently making an app where there will be many context menus possible near the edges of the screen.

@msarsha
Copy link
Owner Author

msarsha commented Feb 21, 2018

I already have the new api ready on my local machine.

Regarding repositioning, I used angular/cdk overlay module, so the cdk is taking care of it.

There is still work to be done, but the basics and the flexibility are there.

I was able to use a custom component as the menu, as well as custom component as a menu item.

I can push it to GitHub as a PR so you can have a look at the progress and share some ideas.

@msarsha msarsha mentioned this issue Feb 22, 2018
@msarsha msarsha closed this as completed Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants