Catch menus back to browser's window area

[AlexLnz]

This is a first approach towards #4 .

[Hughp135]

After looking through your approach, I'm not sure if there is a need for a whole new service just for this functionality.

Is there a reason why you are overriding the position after view init, instead of setting the correct position in sh-context-menu-directive.ts in the setLocation function? It seems the logic could just be added to there and save a lot of extra code.

[AlexLnz]

Hi Hughp135,

Thank you for reviewing the code.

Yes, the code for positioning is in a separate class which does the job.
This follows the "single responsibility principle" of agile software design.

Regarding the second point it's not clear to me what you mean and how to save a lot of extra code. Could you elaborate on this?

regards,
Alex

[Hughp135]

After thinking it through it seems the way you have done it is good (as the problem was a bit more complex than I thought at first). Just need to get my local setup working so I can test it out a bit.

[Hughp135]

Have tested this and it seems to work well with LTR menus, but doesn't work for RTL menus.

Also need to merge in master (and move files from src/app to lib/src).

[msarsha]

implemented with #55

Thanks @AlexLnz .