Skip to content

dts: msm8952: add support for Mobvoi TicWatch Pro 3 LTE (rover) #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dts: msm8952: add support for Mobvoi TicWatch Pro 3 LTE (rover) #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/devices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
- Leeco s2
- Lenovo K5 Play (l38011)
- Lenovo Tab M10 HD (TB-X505X)
- Mobvoi TicWatch Pro 4 LTE (rover) (quirky - see comment in `lk2nd/device/dts/msm8952/sdm429w-mobvoi-rover.dts`)
- Motorola Moto E5 (nora)
- Motorola Moto E5 Plus (hannah) (MSM8917)
- Motorola Moto E5 Plus (hannah) (MSM8937)
Expand Down
1 change: 1 addition & 0 deletions lk2nd/device/dts/msm8952/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ADTBS += \
$(LOCAL_DIR)/msm8976-qrd.dtb \
$(LOCAL_DIR)/sdm429-lenovo-tbx505x.dtb \
$(LOCAL_DIR)/sdm429w-fossil-hoki.dtb \
$(LOCAL_DIR)/sdm429w-mobvoi-rover.dtb \
$(LOCAL_DIR)/sdm439-xiaomi-pine.dtb \

DTBS += \
Expand Down
36 changes: 36 additions & 0 deletions lk2nd/device/dts/msm8952/sdm429w-mobvoi-rover.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// SPDX-License-Identifier: BSD-3-Clause
#include <skeleton64.dtsi>
#include <lk2nd.dtsi>

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is quirky that is how this SoC are working, other dtbo devices documented on the postmarketos wiki maybe we should do the same here.

* This device is quirky.
* To run lk2nd on this device you need to flash custom dtbo.
* Read more https://wiki.postmarketos.org/wiki/Mobvoi_Ticwatch_Pro_3_LTE_(mobvoi-rover)#lk2nd
*/
/ {
qcom,msm-id = <QCOM_ID_SDM429W 0x00>;
qcom,board-id = <0x10b 0x08>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of it, perhaps also qrd v0.1 here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualcomm Technologies, Inc. SDM429 BG WTP

Could be sdm429-bg-wtp? Yes it's also a qrd device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i rename to wtp and add bootloader match to it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the thing uses caf msm/board id then yeah, it's better to use caf naming for the file and have matching, so it's easier to disambiguate later if another device needs same ID

/* Bootloader appears to really want to access symbols */
__symbols__ {};
};

&lk2nd {
model = "Mobvoi TicWatch Pro 3 LTE (rover)";
compatible = "mobvoi,rover";

lk2nd,dtb-files = "sdm429w-mobvoi-rover";

gpio-keys {
compatible = "gpio-keys";

down {
lk2nd,code = <KEY_VOLUMEDOWN>;
gpios = <&tlmm 48 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
};

power {
lk2nd,code = <KEY_POWER>;
gpios = <&pmic_pon GPIO_PMIC_PWRKEY 0>;
};
};
};