Skip to content

dts: msm8916-samsung: add support for another J5 2015 variant (j5ltedx) #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

dts: msm8916-samsung: add support for another J5 2015 variant (j5ltedx) #566

merged 1 commit into from
Aug 10, 2025

Conversation

imnathanzero
Copy link
Contributor

No description provided.

wonderfulShrineMaidenOfParadise
wonderfulShrineMaidenOfParadise reviewed Aug 3, 2025
View reviewed changes
Documentation/devices.md Outdated
- Samsung Galaxy J3 (2016) - SM-J3109, SM-J320YZ
- Samsung Galaxy J3 Pro - SM-J3110, SM-J3119
- Samsung Galaxy J5 (2015) - SM-J5007, SM-J5008, SM-J500F, SM-J500FN, SM-J500H, SM-J500M
- Samsung Galaxy J5 (2015) - SM-J5007, SM-J5008, SM-J500F, SM-J500FN, SM-J500H, SM-J500M, SM-J500G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Samsung Galaxy J5 (2015) - SM-J5007, SM-J5008, SM-J500F, SM-J500FN, SM-J500H, SM-J500M, SM-J500G
- Samsung Galaxy J5 (2015) - SM-J5007, SM-J5008, SM-J500F, SM-J500FN, SM-J500G, SM-J500H, SM-J500M

lk2nd/device/dts/msm8916/msm8916-samsung.dts Outdated
};
};

j5ltedx {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this before j5lteub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for correcting! :)

Copy link
Contributor Author

@imnathanzero imnathanzero Aug 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already pushed, and waiting to be merged

wonderfulShrineMaidenOfParadise
wonderfulShrineMaidenOfParadise suggested changes Aug 3, 2025
View reviewed changes
lk2nd/device/dts/msm8916/msm8916-samsung.dts Outdated
i2c-scl-gpios = <&tlmm 1 I2C_GPIO_FLAGS>;
};
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a tab here

Copy link
Contributor Author

@imnathanzero imnathanzero Aug 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same like others, check line 680

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20250804_151714

Take another look in your text editor and drop this tab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, there's a tab on line 662

My apologies

Already pushed.

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

It would be perfect if the commits are fixed up into single commit by the way.

@imnathanzero
Copy link
Contributor Author

It would be perfect if the commits are fixed up into single commit by the way.

Should i close it and redo these changes again?

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

Should i close it and redo these changes again?

Use git rebase -i origin/main

pick 55154c01 dts: msm8916-samsung: add support for another J5 2015 variant (j5ltedx)
fixup fdb28a2e dts: msm8916-samsung: j5ltedx: fix device listing

# Rebase dcd14a1c..fdb28a2e onto dcd14a1c (2 commands)
#
...

Then save it, and git push --force <your_repo>

@imnathanzero
Copy link
Contributor Author

Should i close it and redo these changes again?

Use git rebase -i origin/main

pick 55154c01 dts: msm8916-samsung: add support for another J5 2015 variant (j5ltedx)
fixup fdb28a2e dts: msm8916-samsung: j5ltedx: fix device listing

# Rebase dcd14a1c..fdb28a2e onto dcd14a1c (2 commands)
#
...

Then save it, and git push --force <your_repo>

Will do, thanks

@imnathanzero
dts: msm8916-samsung: add support for another J5 2015 variant (j5ltedx)
8cd7a45 
Signed-off-by: Nathan Andrew <nathannxx@proton.me>
@TravMurav TravMurav merged commit 658dac8 into msm8916-mainline:main Aug 10, 2025
42 checks passed
@TravMurav
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imnathanzero @wonderfulShrineMaidenOfParadise @TravMurav