add ffi tests & fix ffi #2786
Draft
add ffi tests & fix ffi #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit stumped as to why returning |
Skgland
force-pushed
the
ffi-f64-tests
branch
5 times, most recently
from
f094a95 to
4d08b84
Compare
Skgland
force-pushed
the
ffi-f64-tests
branch
2 times, most recently
from
6fb29af to
e482f1e
Compare
This one was a toughie: it turns out that using `ptr::align_of()`` was a bad idea, since the buffer in `Heap` itself is not aligned to `Heap::heap_cell_alignment()`, so `ptr::align_of()` would sometimes return lower values than expected. That made for an heisenbug: if the alignment of the heap happened to be 4, then the bug wouldn't trigger.
change trait bound order for better
- replace macros with functions - stop abusing allocation error
mthom
force-pushed
the
rebis-dev
branch
3 times, most recently
from
c2b1261 to
3549588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #2777 (comment) and #2777 (comment)
Draft as the tests technically contain UB as they modify the environment in a multi-threaded program.