chore(ui): simplify editing and importing models via YAML #6424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Marshal the config to JSON for the template | ||
| configJSON, err := json.Marshal(modelConfig) | ||
| configData, err := os.ReadFile(modelConfigFile) |
Check failure
Code scanning / gosec
Potential file inclusion via variable Error
There was a problem hiding this comment.
modelConfigFile is not coming from the request, but it's where the config loader module found out the config
| // Write to file | ||
| if err := os.WriteFile(configPath, yamlData, 0644); err != nil { | ||
| // Write new content to file | ||
| if err := os.WriteFile(configPath, body, 0644); err != nil { |
Check failure
Code scanning / gosec
Expect WriteFile permissions to be 0600 or less Error
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the UI to:
The rationale is to avoid having something which feels partially broken-ish, to have instead a simpler but more effective way to manage the configs.
Notes for Reviewers
Signed commits