[code-infra] Add types for markdown loader #47075
Open
+157
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-47075--material-ui.netlify.app/ Bundle size report
|
It was Base UI's types loader that doesn't have proper dependency tracking. This one looks like it's adding dependencies properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few types to better under stand how the code flows wrt webpack cache. May as well commit them for future use. The code didn't alter semantically in any way, it's 100% types.
@dav-is I remember you mentioned before that this loader doesn't do correct dependency tracking. I'm seeing
addDependencyall over the place, did you have a specific case in mind?