Merge pull request #144 from musehq/dev

v2.7.3

Author: alex-shortt

package.json

@@ -1,6 +1,6 @@
 {
   "name": "spacesvr",
-  "version": "2.7.2",
+  "version": "2.7.3",
   "private": true,
   "description": "A standardized reality for future of the 3D Web",
   "keywords": [

src/layers/Environment/ui/PauseMenu/index.tsx

@@ -48,7 +48,7 @@ export default function PauseMenu(props: PauseMenuProps) {
   const PAUSE_ITEMS: PauseItem[] = [
     ...pauseMenuItems,
     {
-      text: "v2.7.2",
+      text: "v2.7.3",
       link: "https://www.npmjs.com/package/spacesvr",
     },
     ...menuItems,

src/tools/Camera/index.tsx

@@ -45,7 +45,7 @@ export function Camera(props: CameraProps) {
     config: config.stiff,
   });
 
-  useRendering(ENABLED, cam, group, mesh, photo.target);
+  useRendering(ENABLED && open, cam, group, mesh, photo.target);
 
   const onClick = useCallback(() => {
     setPressShutter(true);

src/tools/Camera/logic/rendering.ts

@@ -12,7 +12,7 @@ import { useEnvironment } from "../../../layers/Environment";
 import { useThree } from "@react-three/fiber";
 
 export const useRendering = (
-  ENABLED: boolean,
+  enabled: boolean,
   cam: MutableRefObject<PerspectiveCamera | undefined>,
   group: RefObject<Group>,
   mesh: RefObject<Mesh>,
@@ -30,7 +30,7 @@ export const useRendering = (
     if (!paused) prepRendering.current = false;
   }, [paused]);
   useLimitedFrame(1 / 4, (state) => {
-    if (ENABLED || !prepRendering.current || !cam.current) return; // don't double render
+    if (enabled || !prepRendering.current || !cam.current) return; // don't double render
     state.gl.autoClear = true;
     state.gl.setRenderTarget(target);
     state.gl.render(scene, cam.current);
@@ -39,8 +39,7 @@ export const useRendering = (
   });
 
   useLimitedFrame(24, (state) => {
-    if (!cam.current || !mesh.current || !group.current || !ENABLED || !open)
-      return;
+    if (!cam.current || !mesh.current || !group.current || !enabled) return;
 
     // move mesh to camera's position
     mesh.current.getWorldPosition(dummy);